Commit Graph

780 Commits

Author SHA1 Message Date
Jes Sorensen
65064399c2 staging: rtl8723au: Remove ODM_CMNINFO_[RT]X_UNI and related code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen
353cb50dc7 staging: rtl8723au: Remove write-only variables struct dm_priv->{Init,}DMFlag
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen
a0a88236a3 staging: rtl8723au: Remove write-only struct dm_priv->DM_Type variable
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen
45555706d2 staging: rtl8723au: Remove no-op function dm_CheckStatistics()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen
71cd6f54dc staging: rtl8723au: Remove no-op rtl8723a_deinit_dm_priv()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen
c7abd87493 staging: rtl8723au: Remove some redundant check for hw_init_completed
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen
22965e3937 staging: rtl8723au: Remove unused DefaultInitialGain array
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen
3f22aed843 staging: rtl8723au: bDMInitialGainEnable is always true
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen
4d1def6b5c staging: rtl8723au: Declare odm_EdcaTurbo*() functions static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:26 -07:00
Jes Sorensen
9ea3b82630 staging: rtl8723au: Fold odm_EdcaTurboCheck23aCE23a() into odm_EdcaTurboCheck23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21 12:09:25 -07:00
Jes Sorensen
2e8d47e039 staging: rtl8723au: Remove pointless IS_STA_VALID() macro
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen
bc919b0e59 staging: rtl8723au: Remove unused odm_RegDefine11AC.h
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen
344af82c94 staging: rtl8723au: ODM_IC_11N_SERIES is always true for SupportICType
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen
b3ee999e0b staging: rtl8723au: rtl8723a_InitBeaconParameters(): Remove unused variable
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen
2a3bc8aa4f staging: rtl8723au: Use proper name REG_CAMCMD and remove wrapper invalidate_cam_all23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen
e4d480b012 staging: rtl8723au: Remove RegBcnCtrlVal
The value saved in RegBcnCtrlVal was never used. In addition the code
was highly endian broken, declaring it as a u32, then accessing it via
a u8 * later.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen
a2c379ce26 staging: rtl8723au: Remove no-op _InitOperation_mode() function
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen
120036acec staging: rtl8723au: Remove no-op usb_AggSetting*()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen
ef03600cae staging: rtl8723au: Remove write-only variable UsbRxHighSpeedMode
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Raphael Silva
1d69fe84f3 staging: rtl8723au: Corrections in the coding style
Some corrections were made to the code in order to conform to the
Kernel Coding Style.

Jes: Fix build problem

Signed-off-by: Raphael Silva <rapphil@gmail.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen
df72ac93ee staging: rtl8723au: Use rtl8723au_set_media_status() to replace _InitNetworkType()
Reduce yet another duplicate implementation of set_media_status()

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen
6ec262733e staging: rtl8723au: Reduce number of duplicate defines for link state
We use the MSR bits to define link state anyway, so no point having an
additional two sets of defines for the same thing.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen
ee225f0f19 staging: rtl8723au: Eliminate Set_MSR() wrapper call
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-17 17:54:08 -07:00
Jes Sorensen
f6a7125c82 staging: rtl8723au: Remove unncessary wrapper PHY_RFConfig8723A()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-13 12:14:32 -07:00
Jes Sorensen
9464cac7c9 staging: rtl8723au: Remove obfuscating wrapper ODM_ConfigMACWithHeaderFile23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-13 12:14:32 -07:00
Jes Sorensen
f467c2b214 staging: rtl8723au: Remove unused ODM_MacStatusQuery23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-13 12:14:32 -07:00
Jes Sorensen
79756e687c staging: rtl8723au: Remove ugly wrapper ODM_ConfigBBWithHeaderFile23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-13 12:14:32 -07:00
Jes Sorensen
7bafabf2d9 staging: rtl8723au: Remove unused ODM_ReadAndConfig_PHY_REG_PG_8723A() and related code+data
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-13 12:14:32 -07:00
Jes Sorensen
863b61948e staging: rtl8723au: Remove pointless wrappers for calling odm_ConfigRFReg_8723A()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-13 12:14:31 -07:00
Jes Sorensen
d10ef6371e staging: rtl8723au: Remove zero value calculation added to address
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-13 12:14:31 -07:00
Jes Sorensen
6b435adbcb staging: rtl8723au: Eliminate wrapper ODM_ConfigRFWithHeaderFile23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-13 12:14:31 -07:00
Jes Sorensen
a895042573 staging: rtl8723au: Call to ODM_ConfigRFWithHeaderFile23a path is identical for RF_PATH_[AB]
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-13 12:14:31 -07:00
Jes Sorensen
974fe27cec staging: rtl8723au: Remove horrendous code obfuscation READ_AND_CONFIG*()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-13 12:14:31 -07:00
Fabian Frederick
352f145d8f staging: rtl8723au: Remove unnecessary null test before kfree
Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required

Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 15:56:37 -07:00
Jes Sorensen
42f984eb6f staging: rtl8723au: Simplify _BlockWrite() based on saner rtl8723au_writeN()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 15:56:37 -07:00
Jes Sorensen
2786faa33b staging: rtl8723au: Sanitize USB read/write functions
The original Realtek provided functions suffered badly from clutter to
accommodate broken operating systems. Lets try this lean and clean
version instead.

v2: Do not use the stack for data passed to usb_control_msg(). This
    requires reintroducing the mutex used in the old function. In
    addition, get rid of the no longer used 'usb_vendor_req_buf'.
    Note that rtl8723au_writeN() remains unlocked, so it can be used
    for bulk block transfers without having to retake the mutex for
    every write().

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 15:55:59 -07:00
Jes Sorensen
a4f3d3c776 staging: rtl8723au: Remove never set struct rtw_adapter->bNotifyChannelChange
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 15:51:37 -07:00
Jes Sorensen
c3a3e22611 staging: rtl8723au: pwrctrl_priv->ps_flag is never set
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 15:51:37 -07:00
Jes Sorensen
e976cf6f13 staging: rtl8723au: pnp_bstop_trx is never set
In addition remove unused pnp_current_pwr_state

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 15:51:37 -07:00
Jes Sorensen
46eff7392d staging: rtl8723au: Remove unused variables from struct pwrctrl_priv
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 15:51:37 -07:00
Jes Sorensen
bf51ee79fd staging: rtl8723au: Remove unused pwrctrl_priv->brfoffbyhw
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 15:51:37 -07:00
Jes Sorensen
462eb49eae staging: rtl8723au: Fold power_saving_wk_hdl() into rtw_drvextra_cmd_hdl23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 15:51:37 -07:00
Jes Sorensen
c742e339d5 staging: rtl8723au: Clean up rtw_pm_set_ips23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-08 15:51:37 -07:00
Jes Sorensen
80f8210abc staging: rtl8723au: Remove unused rtw_pwr_wakeup_ex()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 20:34:17 -04:00
Jes Sorensen
f2750d9056 staging: rtl8723au: Remove no-op rtl8723a_sreset_linked_status_check()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 20:34:17 -04:00
Jes Sorensen
e899c9176a staging: rtl8723au: sreset_priv->dbg_trigger_point is never set
No point carrying a bunch of code around that is never going to get
called.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 20:34:17 -04:00
Jes Sorensen
63a7cabbd5 staging: rtl8723au: Wifi_Error_Status isn't used for anything
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 20:34:17 -04:00
Jes Sorensen
5a90765817 staging: rtl8723au: Remove unused rtw_sreset_get_wifi_status()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 20:34:17 -04:00
Jes Sorensen
3cf7fa6f8a staging: rtl8723au: rtw_allow_stainfo23a(): Make hwaddr argument const
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 20:34:16 -04:00
Jes Sorensen
25f7190087 staging: rtl8723au: rtw_sta_mgt.c: One copy of the broadcast address should suffice
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26 20:34:16 -04:00