Aaro Koskinen
b9cc16c03d
staging: octeon-usb: eliminate remaining typedef unions
...
Remaining typedef unions can be trivially eliminated with the pattern:
foo_t -> union foo
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:51:50 -07:00
Aaro Koskinen
47509e4a9c
staging: octeon-usb: cvmx_usb_control_header_t -> union cvmx_usb_control_header
...
Replace cvmx_usb_control_header_t with union cvmx_usb_control_header.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:51:49 -07:00
Aaro Koskinen
2bf249e482
staging: octeon-usb: cvmx_usb_internal_state_t -> struct cvmx_usb_internal_state
...
Replace cvmx_usb_internal_state_t with struct cvmx_usb_internal_state.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:51:48 -07:00
Aaro Koskinen
0ff6ac84f9
staging: octeon-usb: cvmx_usb_tx_fifo_t -> struct cvmx_usb_tx_fifo
...
Replace cvmx_usb_tx_fifo_t with struct cvmx_usb_tx_fifo_t.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:51:47 -07:00
Aaro Koskinen
bb06528d6e
staging: octeon-usb: cvmx_usb_pipe_list_t -> struct cvmx_usb_pipe_list
...
Replace cvmx_usb_pipe_list_t with struct cvmx_usb_pipe_list.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:51:46 -07:00
Aaro Koskinen
4ec3ae8412
staging: octeon-usb: cvmx_usb_pipe_t -> struct cvmx_usb_pipe
...
Replace cvmx_usb_pipe_t with struct cvmx_usb_pipe.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:51:46 -07:00
Aaro Koskinen
48f61f832d
staging: octeon-usb: cvmx_usb_transaction_t -> struct cvmx_usb_transaction
...
Replace cvmx_usb_transaction_t with struct cvmx_usb_transaction.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:51:45 -07:00
Aaro Koskinen
a24ed35a19
staging: octeon-usb: cvmx_usb_state_t -> struct cvmx_usb_state
...
Replace cvmx_usb_state_t with struct cvmx_usb_state.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:51:44 -07:00
Aaro Koskinen
6e0e1b0069
staging: octeon-usb: cvmx_usb_iso_packet_t -> struct cvmx_usb_iso_packet
...
Replace cvmx_usb_iso_packet_t with struct cvmx_usb_iso_packet.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:51:43 -07:00
Aaro Koskinen
51a19621cc
staging: octeon-usb: cvmx_usb_port_status_t -> struct cvmx_usb_port_status
...
Replace cvmx_usb_port_status_t with struct cvmx_usb_port_status.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:51:43 -07:00
Aaro Koskinen
03f9adf44c
staging: octeon-usb: cvmx_usb_stage_t -> enum cvmx_usb_stage
...
Replace cvmx_usb_stage_t with enum cvmx_usb_stage.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:50:10 -07:00
Aaro Koskinen
4f1d6ba901
staging: octeon-usb: cvmx_usb_transaction_flags_t -> enum cvmx_usb_transaction_flags
...
Replace cvmx_usb_transaction_flags_t with enum cvmx_usb_transaction_flags.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:50:09 -07:00
Aaro Koskinen
ff9a3e3982
staging: octeon-usb: cvmx_usb_isochronous_flags_t -> enum cvmx_usb_isochronous_flags
...
Replace cvmx_usb_isochronous_flags_t with enum cvmx_usb_isochronous_flags.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:50:08 -07:00
Aaro Koskinen
3f937c51b4
staging: octeon-usb: cvmx_usb_pipe_flags_t -> enum cvmx_usb_pipe_flags
...
Replace cvmx_usb_pipe_flags_t with enum cvmx_usb_pipe_flags.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:50:07 -07:00
Aaro Koskinen
1c25754815
staging: octeon-usb: cvmx_usb_initialize_flags_t -> enum cvmx_usb_initialize_flags
...
Replace cvmx_usb_initialize_flags_t with enum cvmx_usb_initialize_flags.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:50:06 -07:00
Aaro Koskinen
e53b624ae5
staging: octeon-usb: cvmx_usb_callback_t -> enum cvmx_usb_callback
...
Replace cvmx_usb_callback_t with enum cvmx_usb_callback.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:49:06 -07:00
Aaro Koskinen
1c1bdf2764
staging: octeon-usb: cvmx_usb_complete_t -> enum cvmx_usb_complete
...
Replace cvmx_usb_complete_t with enum cvmx_usb_complete.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:49:06 -07:00
Aaro Koskinen
f1e1c1f69e
staging: octeon-usb: cvmx_usb_direction_t -> enum cvmx_usb_direction
...
Replace cvmx_usb_direction_t with enum cvmx_usb_direction.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:49:05 -07:00
Aaro Koskinen
394d4e080f
staging: octeon-usb: cvmx_usb_transfer_t -> enum cvmx_usb_transfer
...
Replace cvmx_usb_transfer_t with enum cvmx_usb_transfer.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:49:04 -07:00
Aaro Koskinen
4918072eb0
staging: octeon-usb: cvmx_usb_speed_t -> enum cvmx_usb_speed
...
Replace cvmx_usb_speed_t with enum cvmx_usb_speed.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-31 17:49:04 -07:00
Aaro Koskinen
12aede9f2f
staging: octeon-usb: cvmx-usb: reformat documentation
...
Reformat the high-level documentation to human readable plain text by
removing HTML and other tags.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:43:29 -07:00
Aaro Koskinen
3d1dc6adf0
staging: octeon-usb: cvmx-usb: delete CVS keyword markers
...
Delete CVS keyword markers.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:43:29 -07:00
Aaro Koskinen
46e0270c25
staging: octeon-usb: cvmx-usb: convert @return
...
Convert "@return" to "Returns: ".
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:43:29 -07:00
Aaro Koskinen
116c163f99
staging: octeon-usb: cvmx-usb: convert @param
...
Convert "@param name" inside comments to "@name:".
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:43:25 -07:00
Aaro Koskinen
a6945527d3
staging: octeon-usb: cvmx-usb: delete duplicated documentation from .h file
...
Delete duplicated function call documentation from the .h file. These
functions are just internal anyway, and the .h file will be completely
removed in the future when the driver will be made a single self-contained
.c file.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:43:24 -07:00
Aaro Koskinen
6995ae41b3
staging: octeon-usb: cvmx-usb: delete @INTERNAL
...
Delete "@INTERNAL" from comments.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:43:23 -07:00
Aaro Koskinen
1084937123
staging: octeon-usb: cvmx-usb: reformat long comments
...
Reformat long comments according to multi-line comment style.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:43:23 -07:00
Aaro Koskinen
eeb90cb287
staging: octeon-usb: cvmx-usb: fix whitespace issues
...
Fix most of the whitespace issues reported by checkpatch:
- use tabs for indentation
- brace placement vs. newlines
- (foo_t*) -> (foo_t *)
- i=0 -> i = 0
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:43:23 -07:00
Aaro Koskinen
95e67a7a29
staging: octeon-usb: cvmx-usb: delete __cvmx_usb_complete_to_string()
...
Delete a redundant function.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:43:23 -07:00
Aaro Koskinen
5645bcf98b
staging: octeon-usb: cvmx-usb: replace cvmx_le16_to_cpu with le16_to_cpu
...
Replace cvmx_le16_to_cpu() with le16_to_cpu().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:43:23 -07:00
Aaro Koskinen
ee7d14ce5e
staging: octeon-usb: cvmx-usb: replace cvmx_wait_usec with udelay
...
Just use udelay().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:41:29 -07:00
Aaro Koskinen
2e5ae89870
staging: octeon-usb: cvmx-usb: replace long udelays with mdelays
...
Replace long udelays with mdelays.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:41:28 -07:00
Aaro Koskinen
27bf55251c
staging: octeon-usb: cvmx-usb: eliminate cvmx_likely/unlikely
...
Just use likely/unlikely.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:41:28 -07:00
Aaro Koskinen
6d658cb2ab
staging: octeon-usb: cvmx-usb: utilize Linux error codes
...
Use generic Linux error codes to replace cvmx_usb_status_t.
The conversion table:
Before After
cvmx_usb_status_t int
CVMX_USB_SUCCESS 0
CVMX_USB_INVALID_PARAM -EINVAL
CVMX_USB_NO_MEMORY -ENOMEM
CVMX_USB_BUSY -EBUSY
CVMX_USB_TIMEOUT -ETIMEDOUT
CVMX_USB_INCORRECT_MODE Deleted (was never used)
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:41:28 -07:00
Aaro Koskinen
684f94ccbd
staging: octeon-usb: cvmx-usb: delete __cplusplus
...
Delete __cplusplus.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:41:28 -07:00
Aaro Koskinen
67f70fc624
staging: octeon-usb: cvmx-usb: delete redundant example code
...
Delete redundant example code found in comments. It's already there in
the driver proper.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:41:28 -07:00
Aaro Koskinen
a7c679482d
staging: octeon-usb: cvmx-usb: delete redundant debug flags
...
Delete redudant debug flags and dead code behind them.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:41:27 -07:00
Aaro Koskinen
1b50850d01
staging: octeon-usb: cvmx-usb: delete driver-specific tracing code
...
Delete call, parameter, and return value tracing.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:41:27 -07:00
Aaro Koskinen
f6ba63fce2
staging: octeon-usb: use correct board type for EdgeRouter Lite
...
Use CVMX_BOARD_TYPE_UBNT_E100 for EdgeRouter Lite.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:41:27 -07:00
Aaro Koskinen
272705e937
staging: octeon-usb: depend on CAVIUM_OCTEON_SOC
...
The USB driver should depend on SOC instead of CPU.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-07-29 11:41:27 -07:00
Aaro Koskinen
d935217df1
staging: octeon-usb: octeon-hcd: eliminate printk()s
...
Replace one printk() with dev_dbg(), and delete the other.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-18 11:17:04 -07:00
Aaro Koskinen
334715f31b
staging: octeon-usb: octeon-hcd: delete commented-out code
...
Delete commented-out code.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-18 11:17:04 -07:00
Aaro Koskinen
87e7e57acd
staging: octeon-usb: octeon-hcd: reformat long comments
...
Fix some comments to fit into 80 colums.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-18 11:17:03 -07:00
Aaro Koskinen
71e06db3b9
staging: octeon-usb: octeon-hcd: use dev_dbg
...
Replace DEBUG macros with dev_dbg. Some less useful are completely
deleted.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-18 11:17:03 -07:00
Aaro Koskinen
f5ed3a3870
staging: octeon-usb: octeon-hcd: make internal variable static
...
Make an internal variable static.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-17 14:53:07 -07:00
Aaro Koskinen
2a81d2b01f
staging: octeon-usb: octeon-hcd: fix some includes
...
Avoid including from "asm/".
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-17 14:51:36 -07:00
Aaro Koskinen
c7609eac88
staging: octeon-usb: octeon-hcd: add missing braces
...
One else branch was missing braces.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-17 14:50:47 -07:00
Aaro Koskinen
771378bb05
staging: octeon-usb: octeon-hcd: use tabs for code indent
...
Replace spaces with tabs where possible.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-17 14:49:14 -07:00
Aaro Koskinen
47d8994bc1
staging: octeon-usb: cvmx-usbnx-defs.h: reformat a comment
...
Reformat a comment to fit it into 80 columns line lenght.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-08 22:04:32 -07:00
Aaro Koskinen
b6bcaa488b
staging: octeon-usb: cvmx-usbnx-defs.h: reformat license text to fit 80 cols
...
Reformat the original license text to fit in 80-column terminal. No
change in wording.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-08 22:04:31 -07:00