Dan Carpenter
02339374cf
Staging: bcm: remove unneeded NULL check
...
The error handling here is wrong. If psIntfAdapter were NULL then we
would have a NULL dereference in the debug output on the error path.
But this function is only called from usbbcm_device_probe() when
psIntfAdapter is non-NULL.
Since the check isn't needed and I removed it instead of fixing it.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:29:56 -07:00
Dan Carpenter
ef5d205645
Staging: bcm: return -EFAULT on copy_to_user() errors
...
bcm/InterfaceDld.c had a couple places which returned the number of
bytes remaining instead of -EFAULT.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:29:56 -07:00
Dan Carpenter
acedadfae5
Staging: bcm: dereferencing before checking
...
I moved the check to see if "Adapter" was null in front of the
dereference.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:29:55 -07:00
Dan Carpenter
055a1eda5f
Staging: bcm: mocro expansion bug
...
The WIMAX_MAX_MTU macro is used in drivers/staging/bcm/CmHost.c like
this:
if (Adapter->PackInfo[uiSearchRuleIndex].uiMaxBucketSize < WIMAX_MAX_MTU * 8)
The multiplication by eight has precedence over the addition so the
macro needs parenthesis to work.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:29:55 -07:00
Dan Carpenter
785698e38d
Staging: bcm: make major and minor signed
...
We assume that major is signed in register_control_device_interface().
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:29:54 -07:00
Dan Carpenter
bf58bd66f6
Staging: bcm: return -EFAULT on copy_to_user() failures
...
There were a number of places in the bcm_char_ioctl() which returned the
number of bytes remaining to be copied instead of returning -EFAULT.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:29:54 -07:00
Tracey Dent
a1823f2ec3
Staging: speakup: devsynth: file_operations should be const
...
Fixed file_operation struct, so that it is const.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:26:25 -07:00
Tracey Dent
1bd15cfd79
Staging: speakup: keyhelp: Coding style fix
...
Put { on previous line, on line 34. Checkpatch.pl caught this.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:26:24 -07:00
Tracey Dent
0c7023b2fb
Staging: speakup: Makefile: Makefile clean up
...
Replaced <modules>-objs with <modules>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:26:24 -07:00
Tracey Dent
8996ba139e
Staging: batman-adv: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y n Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:53 -07:00
Tracey Dent
9a837af5fb
Staging: bcm: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:52 -07:00
Tracey Dent
23d18860db
Staging: comedi: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:52 -07:00
Tracey Dent
1087020fb0
Staging: crystalhd: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:52 -07:00
Tracey Dent
88efaabced
Staging: cx25821: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:51 -07:00
Tracey Dent
77037b4915
Staging: easycap: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:51 -07:00
Tracey Dent
a4f131f07c
Staging: cxt1e1: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:50 -07:00
Tracey Dent
accca6c2f1
Staging: go7007: Makefile: makefile cleanup
...
Changed <module>-objs to <module>-y in Makefile. Also, Replace EXTRA_CFLAGS with ccflags-y
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:50 -07:00
Tracey Dent
bdc1b7bde2
Staging: ft1000:ft1000-pcmia: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:49 -07:00
Tracey Dent
735f48f57d
Staging: et131x: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:49 -07:00
Tracey Dent
23b57e4ae6
Staging: ft1000: ft1000-usb: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:48 -07:00
Tracey Dent
cf5901b3f1
Staging: hv: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:48 -07:00
Tracey Dent
659bd8c1d5
Staging: intel_sst: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:48 -07:00
Tracey Dent
1954cbf0bf
Staging: line6: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:47 -07:00
Tracey Dent
0c26876ea3
Staging: octeon: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:47 -07:00
Tracey Dent
b76d011db1
Staging: rt2870: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:46 -07:00
Tracey Dent
ad52860253
Staging: rt2860: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:46 -07:00
Tracey Dent
79ad8cbfb5
Staging: rtl8187se: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:45 -07:00
Tracey Dent
4580cd7ec2
Staging: rtl8712: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:45 -07:00
Tracey Dent
32a65d4e3b
Staging: sbe-2t3e3: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:45 -07:00
Tracey Dent
5066206242
Staging: smbfs: Makefile: Makefile clean up
...
Changed <module>-objs to <module>-y in Makefile.
Also Replace EXTRA_CFLAGS with ccflags-y.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:44 -07:00
Tracey Dent
a7b1ef250f
Staging: keucr: Makefile: Makefile clean up
...
Changed <module>-objs to <module>-y in Makefile.
Also, Replace EXTRA_CFLAGS with ccflags-y.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:44 -07:00
Tracey Dent
783098ea41
Staging: solo6x10: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:43 -07:00
Tracey Dent
ef3fdeea5d
Staging: wlan-ng: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:43 -07:00
Tracey Dent
aad6b18141
Staging: rtl8192u: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:42 -07:00
Tracey Dent
07790a1f52
Staging: usbip: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:42 -07:00
Tracey Dent
597716d9e2
Staging: zram: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:41 -07:00
Tracey Dent
43dd1d83cd
Staging: xgifb: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:41 -07:00
Tracey Dent
ea195d1a7f
Staging: tm6000: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:41 -07:00
Tracey Dent
6082a68acf
Staging: winbond: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:40 -07:00
Tracey Dent
574c1a6222
Staging: tidspbridge: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:40 -07:00
Tracey Dent
d748241dde
Staging: autofs: Makefile: replace the use of <module>-objs with <module>-y
...
Changed Makefile <module>-objs to <module>-y lines.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:23:39 -07:00
Jonathan Cameron
e58537ccce
staging: iio: update example application.
...
The application is now considerably more generic and should cope
with all devices in tree. The process function will need to be
extended to handle other type values as needed.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:17:57 -07:00
Jonathan Cameron
1755b0ae17
staging: iio: adc add numbers to naming of all adc channels as needed to associate events with them.
...
Given event codes are associated by number not name, all adc channels
including those with names need to have numbers.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:17:56 -07:00
Jonathan Cameron
2f3cc667f7
staging: iio: events update documentation to match new abi.
...
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:17:56 -07:00
Jonathan Cameron
f9f0d354cb
staging: iio: light remove empty light.h file
...
We can put this back when there is something to put in it!
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:17:56 -07:00
Jonathan Cameron
45dd3b340b
staging: iio: tsl2563 event attribute name updates
...
Patch also renames the two raw channels to add numbers
so that we know to which channel the event code applies.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:17:55 -07:00
Jonathan Cameron
d750e375c1
staging: iio: accel remove deprecated and misleading event macros.
...
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:17:55 -07:00
Jonathan Cameron
fc5d0e4254
staging: iio: sca3000 event attribute name updates
...
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:17:54 -07:00
Jonathan Cameron
c33680c483
staging: iio: lis3l02dq event attribute renames
...
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:17:54 -07:00
Jonathan Cameron
4be2de46fb
staging: iio: events move buffer codes so they do not clash with new scheme
...
We could blugeon these more into the scheme I guess, but does it make sense
to do so?
Also remove all remain vestiges of old scheme.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-10-08 07:17:53 -07:00