Commit Graph

607 Commits

Author SHA1 Message Date
Shiva Kerdel
536e973cd7 Staging: wlan-ng: prism2mgmt: Fixed operators spacing style issues
Fixed spaces around operators to fix their coding style issues.

Signed-off-by: Shiva Kerdel <shiva@exdev.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-19 14:21:58 +01:00
Sergio Paracuellos
d349883fb7 staging: wlan-ng: use GENMASK macro in different defines of hfa384x.h
This patch replace actual mask stuff using BIT macros with
or operators to make use of GENMASK macro which simplifies
code clearity and readibility.

It applies for defines included in hfa384x.h header file.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-14 15:43:20 +01:00
Sergio Paracuellos
408fec3ff8 staging: wlan-ng: use GENMASK macro in different defines of p80211hdr.h
This patch replace actual mask stuff using BIT macros with
or operators to make use of GENMASK macro which simplifies
code clearity and readibility.

It applies for defines included in p80211hdr.h header file.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-14 15:43:20 +01:00
Sergio Paracuellos
e49651b836 staging: wlan-ng: use GENMASK macro in define of p80211netdev.h
This patch replace actual mask stuff using BIT macros with
or operators to make use of GENMASK macro which simplifies
code clearity and readibility.

It applies for defines included in p80211netdev.h header file.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-14 15:43:19 +01:00
Sergio Paracuellos
27e8d46094 staging: wlan-ng: use GENMASK macro in two bitwise operations in prism2sta.c
This patch replace actual mask stuff using BIT macros with
or operators to make use of GENMASK macro which simplifies
code clearity and readibility.

It applies for two bitwise operations included in prism2sta.c source file.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-14 15:43:19 +01:00
Sergio Paracuellos
b586fbd396 staging: wlan-ng: remove unnecessary parenthesis in prism2fw.c
This patch removes unnecessary parentheses in different statements of
prism2fw.c file in order to to comply with the standard kernel
coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-10 13:25:33 +01:00
Sergio Paracuellos
98c1a778de staging: wlan-ng: remove unnecessary blank lines in prism2fw.c
This patch removes unnecessary blank lines in prism2fw.c file to
comply with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-10 13:25:33 +01:00
Sergio Paracuellos
86605dd0e7 staging: wlan-ng: fix parenthesis alignment in prism2fw.c
This patch fix open parenthesis alignment matching in prism2fw.c file
to comply with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-10 13:25:33 +01:00
Sergio Paracuellos
e0ae434801 staging: wlan-ng: remove unnecessary blank lines in p80211wep.c
This patch removes unnecessary blank line in p80211wep.c file to
comply with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-10 13:25:33 +01:00
Sergio Paracuellos
d7a711b06e staging: wlan-ng: change comparison to NULL to preferred style.
Comparison to NULL could be written in preferred form.
Change it to comply with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-10 13:25:33 +01:00
Sergio Paracuellos
b1f3b305d4 staging: wlan-ng: match open parenthesis alignment in p80211req.c
This patch fix open parenthesis alignment in p80211req.c file to
comply with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-10 13:25:32 +01:00
Sergio Paracuellos
d1866af104 staging: wlan-ng: match open parenthesis alignment in hfa384x_usb.c
This patch fix open parenthesis alignment in hfa384x_usb.c file to
comply with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-10 13:25:32 +01:00
Sergio Paracuellos
1bca0df4ab staging: wlan-ng: replace BUG_ON() into WARN_ON() on hfa384x_usbin_callback
This patch avoids using BUG_ON() from driver,
and return from hfa384x_usbin_callback with WARN_ON()
if skb was NULL or data in skb is different from expected one.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-10 13:25:32 +01:00
Sergio Paracuellos
3883cd56b5 staging: wlan-ng: remove unnecessary parenthesis in hfa384x_usb.c
This patch removes unnecessary parentheses in different statements of
hfa384x_usb.c file in order to to comply with the standard kernel
coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-10 13:25:32 +01:00
Sergio Paracuellos
0904f84a21 staging: wlan-ng: remove unnecessary out of memory message in p80211conv.c
This patch fix the following checkpatch script warning:
WARNING: Possible unnecessary 'out of memory' message.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-10 13:25:32 +01:00
Sergio Paracuellos
9546780b33 staging: wlan-ng: fix line style issue in macro WLAN_GET_FC_FSTYPE
This patch fix the following checkpatch.pl script warning:
WARNING: line over 80 characters

It also add spaces between or operators inside the macro to
comply with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-10 13:25:32 +01:00
Sergio Paracuellos
388b45377d staging: wlan-ng: remove unnecessary blank line
Blank lines aren't necessary after an open brace '{'.
Clean them in p80211req.c source file to comply with
the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-07 11:32:27 +01:00
Sergio Paracuellos
d4e1818a4c staging: wlan-ng: remove unnecessary parentheses
Avoid no necessary parentheses to comply with the standard kernel
coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-07 11:32:26 +01:00
Sergio Paracuellos
6c55d50e0c staging: wlan-ng: change comparison to NULL to preferred style.
Comparison to NULL could be written in preferred form.
Change it to comply with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-07 11:32:26 +01:00
Sergio Paracuellos
9923df478b staging: wlan-ng: remove two unnecessary blank lines
After open brace or before close brace blank lines are not really
necessary. Remove them.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-07 11:32:26 +01:00
Sergio Paracuellos
f0d4de6a94 staging: wlan-ng: add spaces around or operator : HOSTWEP_DEFAULTKEY_MASK
Add spaces around or operator to comply with the standard
kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-11-07 11:32:26 +01:00
Sergio Paracuellos
e0e6964805 staging: wlan-ng: Replace data type declaration with variable of same type in prism2mgmt.c
sizeof(var) instead of sizeof(struct XXX) is preferred.

It also fix the following checkpatch.pl script warning:
WARNING: line over 80 characters

Fix this two in prism2mgmt.c file.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25 10:48:50 +02:00
Sergio Paracuellos
ab42187a17 staging: wlan-ng: avoid CamelCase: hfa384x_KeyIDChanged
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25 10:44:22 +02:00
Sergio Paracuellos
0c3b2bd7b7 staging: wlan-ng: avoid CamelCase: hfa384x_PSUserCount
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25 10:44:22 +02:00
Sergio Paracuellos
b8f55192ab staging: wlan-ng: avoid CamelCase: hfa384x_AuthRequest
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25 10:44:22 +02:00
Sergio Paracuellos
7190f3f1cf staging: wlan-ng: avoid CamelCase: hfa384x_LinkStatus
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25 10:44:22 +02:00
Sergio Paracuellos
0e2ce9adca staging: wlan-ng: avoid CamelCase: hfa384x_HScanResult
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25 10:44:22 +02:00
Sergio Paracuellos
8f8149de8c staging: wlan-ng: avoid CamelCase: hfa384x_HScanResultSub
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25 10:44:22 +02:00
Sergio Paracuellos
c447358a76 staging: wlan-ng: avoid CamelCase: hfa384x_ChInfoResult
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25 10:44:22 +02:00
Sergio Paracuellos
4cc454f27d staging: wlan-ng: avoid CamelCase: hfa384x_CommTallies16
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25 10:44:22 +02:00
Sergio Paracuellos
c08510e166 staging: wlan-ng: avoid CamelCase in fields of struct hfa384x_dbmcommsquality
Replace CamelCase fields of struct with underscores to comply
with the standard kernel coding style

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25 10:44:22 +02:00
Sergio Paracuellos
162da263c2 staging: wlan-ng: avoid CamelCase: hfa384x_WPAData
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25 10:44:22 +02:00
Sergio Paracuellos
e474b4d4ea staging: wlan-ng: avoid CamelCase: hfa384x_HostScanRequest_data
Replace CamelCase struct name and fields with underscores to comply
with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25 10:44:22 +02:00
Sergio Paracuellos
b937612f9d staging: wlan-ng: avoid CamelCase: HFA384x_RID_CNFAPBCNint
Replace CamelCase define to comply with the standard kernel coding style.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-25 10:44:21 +02:00
sayli karnik
efffed8e06 staging: wlan-ng: cfg80211: Remove unnecessary parentheses around variables
The patch fixes the checkpatch.pl check:
CHECK: Unnecessary parentheses around variable

Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:26:25 +02:00
Sergio Paracuellos
67fafe375a staging: wlan-ng: Replace data type declaration with variable of same type in prism2sta.c
sizeof(*var) instead of sizeof(struct XXX) is preferred.
Fix them in prism2sta.c file.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:26:24 +02:00
Sergio Paracuellos
ec30aebb0d staging: wlan-ng: Replace data type declaration with variable of same type in p80211netdev.c
sizeof(var) instead of sizeof(struct XXX) is preferred.
Fix them in p80211netdev.c

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:26:23 +02:00
Sergio Paracuellos
229dbdc577 staging: wlan-ng: Replace data type declaration with variable of same type in p80211conv.c
sizeof(*var) instead of sizeof(struct XXX) is preferred.
Fix it in p80211conv.c file.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:26:22 +02:00
Sergio Paracuellos
a567d0d47f staging: wlan-ng: Replace data type declaration with variable of same type in hfa384x_usb.c
sizeof(var) instead of sizeof(struct XXX) is preferred.
Fix it in hfa384x_usb.c file.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:26:21 +02:00
Sergio Paracuellos
89e13b4590 staging: wlan-ng: Replace data type declaration with variable of same type in cfg80211.c
sizeof(var) instead of sizeof(struct XXX) is preferred.
Fix it in cfg80211.c file.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:26:20 +02:00
Sergio Paracuellos
d2337a50eb staging: wlan-ng: fix block comments style in prism2mgmt.h
This patch fixes the following checkpatch.pl warning in prism2mgmt.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:56 +02:00
Sergio Paracuellos
1d715f7ec4 staging: wlan-ng: fix block comments style in p80211req.h
This patch fixes the following checkpatch.pl warning in p80211req.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:55 +02:00
Sergio Paracuellos
406c39141a staging: wlan-ng: fix block comments style in p80211netdev.h
This patch fixes the following checkpatch.pl warning in p80211netdev.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:54 +02:00
Sergio Paracuellos
ea0ebda761 staging: wlan-ng: fix block comments style in p80211msg.h
This patch fixes the following checkpatch.pl warning in p80211msg.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:53 +02:00
Sergio Paracuellos
6b168f0b5d staging: wlan-ng: fix block comments style in p80211mgmt.h
This patch fixes the following checkpatch.pl warning in p80211mgmt.h:
 Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:52 +02:00
Sergio Paracuellos
f09fd9bcf6 staging: wlan-ng: fix block comments style in p80211metadef.h
This patch fixes the following checkpatch.pl warning in p80211metadef.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:52 +02:00
Sergio Paracuellos
813ea669c3 staging: wlan-ng: fix block comments style in p80211ioctl.h
This patch fixes the following checkpatch.pl warning in p80211ioctl.h
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:50 +02:00
Sergio Paracuellos
ed2e0f8394 staging: wlan-ng: fix block comments style in p80211hdr.h
This patch fixes the following checkpatch.pl warning in p80211hdr.h:
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:50 +02:00
Sergio Paracuellos
3ae3a74736 staging: wlan-ng: fix block comments style in p80211conv.h
This patch fixes the following checkpatch.pl warning in p80211conv.h:
Block comments should align the * on each line

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:49 +02:00
Sergio Paracuellos
cfea8abf67 staging: wlan-ng: get memory from kernel allocators instead of big static buffer
This patch fix the following sparse warnings in prism2fw.c:
warning: memset with byte count of 120000

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16 10:25:45 +02:00