leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

s390/scm_blk: fix memleak in init function

Browse Source 
If the allocation of a single request fails the already allocated
requests will not be freed.

Reviewed-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
This commit is contained in:
Sebastian Ott 2013-04-25 13:03:18 +02:00 committed by Martin Schwidefsky
parent bd86055fc9
commit fff60fabc7
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/s390/block/scm_blk.c
View File

@ -465,7 +465,7 @@ static int __init scm_blk_init(void)
scm_major = ret; scm_major = ret;
ret = scm_alloc_rqs(nr_requests); ret = scm_alloc_rqs(nr_requests);
if (ret) if (ret)
goto out_unreg; goto out_free;
scm_debug = debug_register("scm_log", 16, 1, 16); scm_debug = debug_register("scm_log", 16, 1, 16);
if (!scm_debug) { if (!scm_debug) {
@ -486,7 +486,6 @@ out_dbf:
debug_unregister(scm_debug); debug_unregister(scm_debug);
out_free: out_free:
scm_free_rqs(); scm_free_rqs();
out_unreg:
unregister_blkdev(scm_major, "scm"); unregister_blkdev(scm_major, "scm");
out: out:
return ret; return ret;