leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

V4L/DVB (13117): gspca - pac7311: remove magic value for SKIP.

Browse Source 
Change the magic value 0xaa to SKIP for better understandability.

Signed-off-by: Marton Nemeth <nm127@freemail.hu>
Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Marton Nemeth 2009-10-04 13:51:26 -03:00 committed by Mauro Carvalho Chehab
parent 518c8df77c
commit ff75e99c62
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/media/video/gspca/pac7311.c
View File

@ -316,7 +316,8 @@ static const __u8 start_7302[] = {
0, 0 /* end of sequence */
};
/* page 3 - the value 0xaa says skip the index - see reg_w_page() */
#define SKIP 0xaa
/* page 3 - the value SKIP says skip the index - see reg_w_page() */
static const __u8 page3_7302[] = {
0x90, 0x40, 0x03, 0x50, 0xc2, 0x01, 0x14, 0x16,
0x14, 0x12, 0x00, 0x00, 0x00, 0x02, 0x33, 0x00,
@ -383,13 +384,13 @@ static const __u8 start_7311[] = {
0, 0 /* end of sequence */
};
/* page 4 - the value 0xaa says skip the index - see reg_w_page() */
/* page 4 - the value SKIP says skip the index - see reg_w_page() */
static const __u8 page4_7311[] = {
0xaa, 0xaa, 0x04, 0x54, 0x07, 0x2b, 0x09, 0x0f,
0x09, 0x00, 0xaa, 0xaa, 0x07, 0x00, 0x00, 0x62,
0x08, 0xaa, 0x07, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x03, 0xa0, 0x01, 0xf4, 0xaa,
0xaa, 0x00, 0x08, 0xaa, 0x03, 0xaa, 0x00, 0x68,
SKIP, SKIP, 0x04, 0x54, 0x07, 0x2b, 0x09, 0x0f,
0x09, 0x00, SKIP, SKIP, 0x07, 0x00, 0x00, 0x62,
0x08, SKIP, 0x07, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x03, 0xa0, 0x01, 0xf4, SKIP,
SKIP, 0x00, 0x08, SKIP, 0x03, SKIP, 0x00, 0x68,
0xca, 0x10, 0x06, 0x78, 0x00, 0x00, 0x00, 0x00,
0x23, 0x28, 0x04, 0x11, 0x00, 0x00
};
@ -438,7 +439,7 @@ static void reg_w_page(struct gspca_dev *gspca_dev,
int index;
for (index = 0; index < len; index++) {
if (page[index] == 0xaa) /* skip this index */
if (page[index] == SKIP) /* skip this index */
continue;
gspca_dev->usb_buf[0] = page[index];
usb_control_msg(gspca_dev->dev,