qlogic: netxen: constify bin_attribute structures
Declare bin_attribute structures as const as they are only passed as an
arguments to the functions device_remove_bin_file and
device_create_bin_file. These function arguments are of type const, so
bin_attribute structures having this property can be made const too.
Done using Coccinelle:
@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct bin_attribute i@p = {...};
@ok1@
identifier r1.i;
position p,p1;
@@
(
device_remove_bin_file(...,&i@p)
|
device_create_bin_file(..., &i@p1)
)
@bad@
position p!={r1.p,ok1.p,ok1.p1};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct bin_attribute i;
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
0ccea2210c
commit
ff2924583b
@@ -3005,14 +3005,14 @@ static ssize_t netxen_sysfs_write_mem(struct file *filp, struct kobject *kobj,
|
||||
}
|
||||
|
||||
|
||||
static struct bin_attribute bin_attr_crb = {
|
||||
static const struct bin_attribute bin_attr_crb = {
|
||||
.attr = {.name = "crb", .mode = (S_IRUGO | S_IWUSR)},
|
||||
.size = 0,
|
||||
.read = netxen_sysfs_read_crb,
|
||||
.write = netxen_sysfs_write_crb,
|
||||
};
|
||||
|
||||
static struct bin_attribute bin_attr_mem = {
|
||||
static const struct bin_attribute bin_attr_mem = {
|
||||
.attr = {.name = "mem", .mode = (S_IRUGO | S_IWUSR)},
|
||||
.size = 0,
|
||||
.read = netxen_sysfs_read_mem,
|
||||
@@ -3141,7 +3141,7 @@ out:
|
||||
|
||||
}
|
||||
|
||||
static struct bin_attribute bin_attr_dimm = {
|
||||
static const struct bin_attribute bin_attr_dimm = {
|
||||
.attr = { .name = "dimm", .mode = (S_IRUGO | S_IWUSR) },
|
||||
.size = sizeof(struct netxen_dimm_cfg),
|
||||
.read = netxen_sysfs_read_dimm,
|
||||
|
||||
Reference in New Issue
Block a user