leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "security: inode: fix a missing check for securityfs_create_file"

Browse Source 
This reverts commit d1a0846006.

From Al Viro:

"Rather bad way to do it - generally, register_filesystem() should be
the last thing done by initialization.  Any modular code that
does unregister_filesystem() on failure exit is flat-out broken;
here it's not instantly FUBAR, but it's a bloody bad example.

What's more, why not let simple_fill_super() do it?  Just
static int fill_super(struct super_block *sb, void *data, int silent)
{
        static const struct tree_descr files[] = {
                {"lsm", &lsm_ops, 0444},
                {""}
        };

and to hell with that call of securityfs_create_file() and all its
failure handling..."

Signed-off-by: James Morris <james.morris@microsoft.com>
This commit is contained in:
James Morris 2019-04-10 14:59:20 -07:00
parent ecb8e74dac
commit fe9fd2ef38
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
security/inode.c
View File

@ -339,11 +339,6 @@ static int __init securityfs_init(void)
#ifdef CONFIG_SECURITY #ifdef CONFIG_SECURITY
lsm_dentry = securityfs_create_file("lsm", 0444, NULL, NULL, lsm_dentry = securityfs_create_file("lsm", 0444, NULL, NULL,
&lsm_ops); &lsm_ops);
if (IS_ERR(lsm_dentry)) {
unregister_filesystem(&fs_type);
sysfs_remove_mount_point(kernel_kobj, "security");
return PTR_ERR(lsm_dentry);
}
#endif #endif
return 0; return 0;
} }