IB/rxe: replace refcount_inc with skb_get

Follow the advice from Bart, the function refcount_inc is replaced
with skb_get in commit 99dae69025 ("IB/rxe: optimize mcast recv process")
and commit 86af617641 ("IB/rxe: remove unnecessary skb_clone").

CC: Srinivas Eeda <srinivas.eeda@oracle.com>
CC: Junxiao Bi <junxiao.bi@oracle.com>
Suggested-by: Bart Van Assche <Bart.VanAssche@wdc.com>
Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
Zhu Yanjun 2018-04-10 09:37:39 -04:00 committed by Doug Ledford
parent 2e47350789
commit fe896ceb57
2 changed files with 2 additions and 2 deletions

View File

@ -311,7 +311,7 @@ static void rxe_rcv_mcast_pkt(struct rxe_dev *rxe, struct sk_buff *skb)
* increase the users of the skb then post to the next qp * increase the users of the skb then post to the next qp
*/ */
if (mce->qp_list.next != &mcg->qp_list) if (mce->qp_list.next != &mcg->qp_list)
refcount_inc(&skb->users); skb_get(skb);
pkt->qp = qp; pkt->qp = qp;
rxe_add_ref(qp); rxe_add_ref(qp);

View File

@ -990,7 +990,7 @@ static int send_atomic_ack(struct rxe_qp *qp, struct rxe_pkt_info *pkt,
memset((unsigned char *)SKB_TO_PKT(skb) + sizeof(ack_pkt), 0, memset((unsigned char *)SKB_TO_PKT(skb) + sizeof(ack_pkt), 0,
sizeof(skb->cb) - sizeof(ack_pkt)); sizeof(skb->cb) - sizeof(ack_pkt));
refcount_inc(&skb->users); skb_get(skb);
res->type = RXE_ATOMIC_MASK; res->type = RXE_ATOMIC_MASK;
res->atomic.skb = skb; res->atomic.skb = skb;
res->first_psn = ack_pkt.psn; res->first_psn = ack_pkt.psn;