leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wireless: wl12xx, fix lock imbalance

Browse Source 
Add omitted mutex_unlock to one of wl12xx_op_start fail paths (when
wl12xx_chip_wakeup fails).

[v2]
Power off the device, because:
\= cite from http://marc.info/?l=linux-kernel&m=124755028209880&w=2
If the chip cannot be booted, why should it remain powered on?
In some rare cases, the chip might fail to initialize, but can
recover if powered off and on again, so turning it off at this
point is the right thing to do. =/

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Jiri Slaby 2009-07-14 22:37:13 +02:00 committed by John W. Linville
parent a94ca4e7af
commit fe643414db
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/wireless/wl12xx/wl1251_main.c
View File

@ -349,7 +349,7 @@ static int wl1251_op_start(struct ieee80211_hw *hw)
ret = wl1251_chip_wakeup(wl);
if (ret < 0)
return ret;
goto out;
ret = wl->chip.op_boot(wl);
if (ret < 0)