leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: gdm724x: fix use after free in gdm_lte_rx()

Browse Source 
The netif_rx_ni() function frees the skb so we can't dereference it to
save the skb->len.

Fixes: 61e1210476 ("staging: gdm7240: adding LTE USB driver")
Cc: stable <stable@vger.kernel.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220228074331.GA13685@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2022-02-28 10:43:31 +03:00 committed by Greg Kroah-Hartman
parent 7e57714cd0
commit fc7f750dc9
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/gdm724x/gdm_lte.c
View File

@ -76,14 +76,15 @@ static void tx_complete(void *arg)
static int gdm_lte_rx(struct sk_buff *skb, struct nic *nic, int nic_type) static int gdm_lte_rx(struct sk_buff *skb, struct nic *nic, int nic_type)
{ {
int ret; int ret, len;
len = skb->len + ETH_HLEN;
ret = netif_rx_ni(skb); ret = netif_rx_ni(skb);
if (ret == NET_RX_DROP) { if (ret == NET_RX_DROP) {
nic->stats.rx_dropped++; nic->stats.rx_dropped++;
} else { } else {
nic->stats.rx_packets++; nic->stats.rx_packets++;
nic->stats.rx_bytes += skb->len + ETH_HLEN; nic->stats.rx_bytes += len;
} }
return 0; return 0;