leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: gadget: f_printer: use non-zero flag for bitwise and

Browse Source 
USB_DIR_OUT happens to be zero, so the result of bitwise and is always 0.
Consequently, break will never happen in the SOFT_RESET case.
This patch uses a compatible condition with a non-zero USB_DIR_IN,
which might or might not evaluate to zero.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Andrzej Pietrasiewicz 2015-03-13 11:08:08 +01:00 committed by Felipe Balbi
parent 2bb2077ee6
commit fbdecad99c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/usb/gadget/function/f_printer.c
View File

@ -918,7 +918,7 @@ static bool gprinter_req_match(struct usb_function *f,
return false;
case SOFT_RESET:
if (!w_value && !w_length &&
(USB_DIR_OUT & ctrl->bRequestType))
!(USB_DIR_IN & ctrl->bRequestType))
break;
/* fall through */
default: