leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

zorro: Drop useless (and hardly used) .driver member in struct zorro_dev

Browse Source 
The only actual use is to check in zorro_device_probe() that the device
isn't already bound. The driver core already ensures this however so the
check can go away which allows to drop the then assigned-only member
from struct zorro_dev.

If the value was indeed needed somewhere it can always be calculated by

	to_zorro_driver(z->dev.driver)

.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210730191035.1455248-5-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Uwe Kleine-König 2021-07-30 21:10:35 +02:00 committed by Greg Kroah-Hartman
parent 18d214cc1d
commit fac58b4a52
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/zorro/zorro-driver.c
View File

@ -47,16 +47,14 @@ static int zorro_device_probe(struct device *dev)
struct zorro_driver *drv = to_zorro_driver(dev->driver); struct zorro_driver *drv = to_zorro_driver(dev->driver);
struct zorro_dev *z = to_zorro_dev(dev); struct zorro_dev *z = to_zorro_dev(dev);
if (!z->driver && drv->probe) { if (drv->probe) {
const struct zorro_device_id *id; const struct zorro_device_id *id;
id = zorro_match_device(drv->id_table, z); id = zorro_match_device(drv->id_table, z);
if (id) if (id)
error = drv->probe(z, id); error = drv->probe(z, id);
if (error >= 0) { if (error >= 0)
z->driver = drv;
error = 0; error = 0;
}
} }
return error; return error;
} }
@ -69,7 +67,6 @@ static void zorro_device_remove(struct device *dev)
if (drv->remove) if (drv->remove)
drv->remove(z); drv->remove(z);
z->driver = NULL;
} }

1
include/linux/zorro.h
View File

@ -29,7 +29,6 @@
struct zorro_dev { struct zorro_dev {
struct ExpansionRom rom; struct ExpansionRom rom;
zorro_id id; zorro_id id;
struct zorro_driver *driver; /* which driver has allocated this device */
struct device dev; /* Generic device interface */ struct device dev; /* Generic device interface */
u16 slotaddr; u16 slotaddr;
u16 slotsize; u16 slotsize;