From fa8db3989362866ea1beb1314fc4e86f373a6425 Mon Sep 17 00:00:00 2001 From: Len Baker Date: Sat, 17 Jul 2021 18:05:12 +0200 Subject: [PATCH] staging/most: Remove all strcpy() uses in favor of strscpy() strcpy() performs no bounds checking on the destination buffer. This could result in linear overflows beyond the end of the buffer, leading to all kinds of misbehaviors. The safe replacement is strscpy(). Signed-off-by: Len Baker Link: https://lore.kernel.org/r/20210717160512.16176-1-len.baker@gmx.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/most/video/video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c index 90933d78c332..b7858e47145f 100644 --- a/drivers/staging/most/video/video.c +++ b/drivers/staging/most/video/video.c @@ -258,7 +258,7 @@ static int vidioc_enum_fmt_vid_cap(struct file *file, void *priv, if (f->index) return -EINVAL; - strcpy(f->description, "MPEG"); + strscpy(f->description, "MPEG", sizeof(f->description)); f->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; f->flags = V4L2_FMT_FLAG_COMPRESSED; f->pixelformat = V4L2_PIX_FMT_MPEG; @@ -306,7 +306,7 @@ static int vidioc_enum_input(struct file *file, void *priv, if (input->index >= V4L2_CMP_MAX_INPUT) return -EINVAL; - strcpy(input->name, "MOST Video"); + strscpy(input->name, "MOST Video", sizeof(input->name)); input->type |= V4L2_INPUT_TYPE_CAMERA; input->audioset = 0;