leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

firmware: tegra: Switch over to memdup_user()

Browse Source 
This patch fixes the following Coccinelle warning:

drivers/firmware/tegra/bpmp-debugfs.c:379: WARNING opportunity for memdup_user

Use memdup_user() rather than duplicating its implementation. This is a
little bit restricted to reduce false positives.

Signed-off-by: Qing Wang <wangqing@vivo.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
This commit is contained in:
Qing Wang 2021-10-18 04:31:52 -07:00 committed by Thierry Reding
parent 568035b01c
commit fa586abcfe
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/firmware/tegra/bpmp-debugfs.c
View File

@ -377,18 +377,11 @@ static ssize_t bpmp_debug_store(struct file *file, const char __user *buf,
if (!filename) if (!filename)
return -ENOENT; return -ENOENT;
databuf = kmalloc(count, GFP_KERNEL); databuf = memdup_user(buf, count);
if (!databuf) if (IS_ERR(databuf))
return -ENOMEM; return PTR_ERR(databuf);
if (copy_from_user(databuf, buf, count)) {
err = -EFAULT;
goto free_ret;
}
err = mrq_debug_write(bpmp, filename, databuf, count); err = mrq_debug_write(bpmp, filename, databuf, count);
free_ret:
kfree(databuf); kfree(databuf);
return err ?: count; return err ?: count;