leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: dsa: sja1105: Reverse TPID and TPID2

Browse Source 
>From reading the P/Q/R/S user manual, it appears that TPID is used by
the switch for detecting S-tags and TPID2 for C-tags.  Their meaning is
not clear from the E/T manual.

Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Vladimir Oltean 2019-06-08 15:04:31 +03:00 committed by David S. Miller
parent 070ca3bb95
commit f9a1a7646c
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/dsa/sja1105/sja1105_main.c
View File

@ -1421,8 +1421,8 @@ static int sja1105_vlan_filtering(struct dsa_switch *ds, int port, bool enabled)
if (enabled) { if (enabled) {
/* Enable VLAN filtering. */ /* Enable VLAN filtering. */
tpid = ETH_P_8021Q; tpid = ETH_P_8021AD;
tpid2 = ETH_P_8021AD; tpid2 = ETH_P_8021Q;
} else { } else {
/* Disable VLAN filtering. */ /* Disable VLAN filtering. */
tpid = ETH_P_SJA1105; tpid = ETH_P_SJA1105;
@ -1431,7 +1431,9 @@ static int sja1105_vlan_filtering(struct dsa_switch *ds, int port, bool enabled)
table = &priv->static_config.tables[BLK_IDX_GENERAL_PARAMS]; table = &priv->static_config.tables[BLK_IDX_GENERAL_PARAMS];
general_params = table->entries; general_params = table->entries;
/* EtherType used to identify outer tagged (S-tag) VLAN traffic */
general_params->tpid = tpid; general_params->tpid = tpid;
/* EtherType used to identify inner tagged (C-tag) VLAN traffic */
general_params->tpid2 = tpid2; general_params->tpid2 = tpid2;
rc = sja1105_static_config_reload(priv); rc = sja1105_static_config_reload(priv);