leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drbd: bm_page_async_io: properly initialize page->private

Browse Source 
If bm_page_async_io is advised to use a new page for I/O
(BM_AIO_COPY_PAGES is set), it will get it from a mempool.
Once the mempool has to dip into its reserves the page is
not reinitialized, i.e. page->private contains garbage, which
will lead to various problems once the I/O completes (dereferences
of NULL pointers, the submitting thread getting stuck in D-state,
 ...).

Signed-off-by: Arne Redlich <arne.redlich@googlemail.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
This commit is contained in:
Lars Ellenberg 2012-05-07 13:04:03 +02:00 committed by Philipp Reisner
parent a220d29180
commit f66ee69746
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/block/drbd/drbd_bitmap.c
View File

@ -200,7 +200,7 @@ void drbd_bm_unlock(struct drbd_conf *mdev)
static void bm_store_page_idx(struct page *page, unsigned long idx) static void bm_store_page_idx(struct page *page, unsigned long idx)
{ {
BUG_ON(0 != (idx & ~BM_PAGE_IDX_MASK)); BUG_ON(0 != (idx & ~BM_PAGE_IDX_MASK));
page_private(page) |= idx; set_page_private(page, idx);
} }
static unsigned long bm_page_to_idx(struct page *page) static unsigned long bm_page_to_idx(struct page *page)