leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

habanalabs: send device activity in a proper context

Browse Source 
'Device activity open packet' should be sent outside of mutex as
there is no real necessity for a lock.
In addition 'device activity close packet' should be sent upon an
actual release of the device.

Signed-off-by: Ofir Bitton <obitton@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
This commit is contained in:
Ofir Bitton 2022-08-28 12:46:27 +03:00 committed by Oded Gabbay
parent 4745b2f0d0
commit f5ec364c9e
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/misc/habanalabs/common/device.c
View File

@ -363,6 +363,8 @@ static void hpriv_release(struct kref *ref)
hdev = hpriv->hdev;
hdev->asic_funcs->send_device_activity(hdev, false);
put_pid(hpriv->taskpid);
hl_debugfs_remove_file(hpriv);
@ -470,8 +472,6 @@ static int hl_device_release(struct inode *inode, struct file *filp)
hdev->last_open_session_duration_jif =
jiffies - hdev->last_successful_open_jif;
hdev->asic_funcs->send_device_activity(hdev, false);
return 0;
}

4
drivers/misc/habanalabs/common/habanalabs_drv.c
View File

@ -204,11 +204,11 @@ int hl_device_open(struct inode *inode, struct file *filp)
goto out_err;
}
rc = hdev->asic_funcs->send_device_activity(hdev, true);
list_add(&hpriv->dev_node, &hdev->fpriv_list);
mutex_unlock(&hdev->fpriv_list_lock);
hdev->asic_funcs->send_device_activity(hdev, true);
hl_debugfs_add_file(hpriv);
atomic_set(&hdev->last_error.cs_timeout.write_enable, 1);