leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

serial: stm32: fix startup by enabling usart for reception

Browse Source 
RX is configured, but usart is not enabled in startup function.
Kernel documentation specifies that startup should enable the port for
reception.
Fix the startup by enabling usart for reception.

Fixes: 84872dc448 ("serial: stm32: add RX and TX FIFO flush")
Signed-off-by: Erwan Le Ray <erwan.leray@foss.st.com>
Link: https://lore.kernel.org/r/20210304162308.8984-3-erwan.leray@foss.st.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Erwan Le Ray 2021-03-04 17:22:57 +01:00 committed by Greg Kroah-Hartman
parent 87fd0741d6
commit f4518a8a75
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/tty/serial/stm32-usart.c
View File

@ -634,6 +634,7 @@ static int stm32_usart_startup(struct uart_port *port)
{ {
struct stm32_port *stm32_port = to_stm32_port(port); struct stm32_port *stm32_port = to_stm32_port(port);
const struct stm32_usart_offsets *ofs = &stm32_port->info->ofs; const struct stm32_usart_offsets *ofs = &stm32_port->info->ofs;
const struct stm32_usart_config *cfg = &stm32_port->info->cfg;
const char *name = to_platform_device(port->dev)->name; const char *name = to_platform_device(port->dev)->name;
u32 val; u32 val;
int ret; int ret;
@ -658,7 +659,7 @@ static int stm32_usart_startup(struct uart_port *port)
} }
/* RX FIFO enabling */ /* RX FIFO enabling */
val = stm32_port->cr1_irq | USART_CR1_RE; val = stm32_port->cr1_irq | USART_CR1_RE | BIT(cfg->uart_enable_bit);
if (stm32_port->fifoen) if (stm32_port->fifoen)
val |= USART_CR1_FIFOEN; val |= USART_CR1_FIFOEN;
stm32_usart_set_bits(port, ofs->cr1, val); stm32_usart_set_bits(port, ofs->cr1, val);