leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drm/vmwgfx/vmwgfx_drv: Fix an error path in vmw_setup_pci_resources()

Browse Source 
The devm_memremap() function never returns NULL, it returns error
pointers so the test needs to be fixed.  Also we need to call
pci_release_regions() to avoid a memory leak.

Fixes: be4f77ac68 ("drm/vmwgfx: Cleanup fifo mmio handling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Zack Rusin <zackr@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/YA6FMboLhnE3uSvb@mwanda
This commit is contained in:
Dan Carpenter 2021-01-25 11:45:37 +03:00 committed by Zack Rusin
parent e7cbc68a28
commit f3ebd4e6b6
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
View File

@ -668,9 +668,10 @@ static int vmw_setup_pci_resources(struct vmw_private *dev,
fifo_size, fifo_size,
MEMREMAP_WB); MEMREMAP_WB);
if (unlikely(dev->fifo_mem == NULL)) { if (IS_ERR(dev->fifo_mem)) {
DRM_ERROR("Failed mapping FIFO memory.\n"); DRM_ERROR("Failed mapping FIFO memory.\n");
return -ENOMEM; pci_release_regions(pdev);
return PTR_ERR(dev->fifo_mem);
} }
/* /*