leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[media] stk1160: unlock on error path stk1160_set_alternate()

Browse Source 
There are some unlocks missing on error.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Dan Carpenter 2012-08-14 02:59:48 -03:00 committed by Mauro Carvalho Chehab
parent a7bd775628
commit f367cc1efe
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/media/usb/stk1160/stk1160-v4l.c
View File

@ -159,8 +159,9 @@ static bool stk1160_set_alternate(struct stk1160 *dev)
static int stk1160_start_streaming(struct stk1160 *dev)
{
int i, rc;
bool new_pkt_size;
int rc = 0;
int i;
/* Check device presence */
if (!dev->udev)
@ -183,7 +184,7 @@ static int stk1160_start_streaming(struct stk1160 *dev)
if (!dev->isoc_ctl.num_bufs || new_pkt_size) {
rc = stk1160_alloc_isoc(dev);
if (rc < 0)
return rc;
goto out_unlock;
}
/* submit urbs and enables IRQ */
@ -192,7 +193,7 @@ static int stk1160_start_streaming(struct stk1160 *dev)
if (rc) {
stk1160_err("cannot submit urb[%d] (%d)\n", i, rc);
stk1160_uninit_isoc(dev);
return rc;
goto out_unlock;
}
}
@ -205,9 +206,10 @@ static int stk1160_start_streaming(struct stk1160 *dev)
stk1160_dbg("streaming started\n");
out_unlock:
mutex_unlock(&dev->v4l_lock);
return 0;
return rc;
}
/* Must be called with v4l_lock hold */