leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: mt7621-pinctrl: Test devm_kzalloc for failure while improving the code

Browse Source 
This patch tests the return of devm_kzalloc for failure and
improves the code.

Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Nishad Kamdar 2019-01-29 21:15:12 +05:30 committed by Greg Kroah-Hartman
parent 6ffcce4178
commit f2829d070f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
View File

@ -350,7 +350,6 @@ static int rt2880_pinmux_probe(struct platform_device *pdev)
for_each_compatible_node(np, NULL, "ralink,rt2880-gpio") { for_each_compatible_node(np, NULL, "ralink,rt2880-gpio") {
const __be32 *ngpio, *gpiobase; const __be32 *ngpio, *gpiobase;
struct pinctrl_gpio_range *range; struct pinctrl_gpio_range *range;
char *name;
if (!of_device_is_available(np)) if (!of_device_is_available(np))
continue; continue;
@ -362,9 +361,10 @@ static int rt2880_pinmux_probe(struct platform_device *pdev)
return -EINVAL; return -EINVAL;
} }
range = devm_kzalloc(p->dev, sizeof(*range) + 4, GFP_KERNEL); range = devm_kzalloc(p->dev, sizeof(*range), GFP_KERNEL);
range->name = name = (char *)&range[1]; if (!range)
sprintf(name, "pio"); return -ENOMEM;
range->name = "pio";
range->npins = __be32_to_cpu(*ngpio); range->npins = __be32_to_cpu(*ngpio);
range->base = __be32_to_cpu(*gpiobase); range->base = __be32_to_cpu(*gpiobase);
range->pin_base = range->base; range->pin_base = range->base;