leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] USB: usbatm kcalloc cleanup

Browse Source 
you seem to have applied the original, not the new improved one with
whiter teeth that uses kcalloc instead of kmalloc + memset.  Here's a
patch that goes on top of the one you applied.

Signed-off-by: Duncan Sands <baldrick@free.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Duncan Sands 2005-05-28 22:06:20 +02:00 committed by Greg Kroah-Hartman
parent 843c944fb8
commit f070693009
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/usb/atm/usbatm.c
View File

@ -949,7 +949,6 @@ int usbatm_usb_probe(struct usb_interface *intf, const struct usb_device_id *id,
struct usb_device *usb_dev = interface_to_usbdev(intf); struct usb_device *usb_dev = interface_to_usbdev(intf);
struct usbatm_data *instance; struct usbatm_data *instance;
char *buf; char *buf;
size_t instance_size = sizeof(*instance) + sizeof(struct urb *) * (num_rcv_urbs + num_snd_urbs);
int error = -ENOMEM; int error = -ENOMEM;
int i, length; int i, length;
int need_heavy; int need_heavy;
@ -961,14 +960,12 @@ int usbatm_usb_probe(struct usb_interface *intf, const struct usb_device_id *id,
intf->altsetting->desc.bInterfaceNumber); intf->altsetting->desc.bInterfaceNumber);
/* instance init */ /* instance init */
instance = kmalloc(instance_size, GFP_KERNEL); instance = kcalloc(1, sizeof(*instance) + sizeof(struct urb *) * (num_rcv_urbs + num_snd_urbs), GFP_KERNEL);
if (!instance) { if (!instance) {
dev_dbg(dev, "%s: no memory for instance data!\n", __func__); dev_dbg(dev, "%s: no memory for instance data!\n", __func__);
return -ENOMEM; return -ENOMEM;
} }
memset(instance, 0, instance_size);
/* public fields */ /* public fields */
instance->driver = driver; instance->driver = driver;