leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: ethernet: davinci_emac: use phy_ethtool_{get|set}_link_ksettings

Browse Source 
There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.

Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Philippe Reynes 2016-07-02 00:02:35 +02:00 committed by David S. Miller
parent c332177e5e
commit efb15c3964
1 changed files with 2 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
drivers/net/ethernet/ti/davinci_emac.c
View File

@ -484,41 +484,6 @@ static void emac_get_drvinfo(struct net_device *ndev,
strlcpy(info->version, EMAC_MODULE_VERSION, sizeof(info->version)); strlcpy(info->version, EMAC_MODULE_VERSION, sizeof(info->version));
} }
/**
* emac_get_settings - Get EMAC settings
* @ndev: The DaVinci EMAC network adapter
* @ecmd: ethtool command
*
* Executes ethool get command
*
*/
static int emac_get_settings(struct net_device *ndev,
struct ethtool_cmd *ecmd)
{
if (ndev->phydev)
return phy_ethtool_gset(ndev->phydev, ecmd);
else
return -EOPNOTSUPP;
}
/**
* emac_set_settings - Set EMAC settings
* @ndev: The DaVinci EMAC network adapter
* @ecmd: ethtool command
*
* Executes ethool set command
*
*/
static int emac_set_settings(struct net_device *ndev, struct ethtool_cmd *ecmd)
{
if (ndev->phydev)
return phy_ethtool_sset(ndev->phydev, ecmd);
else
return -EOPNOTSUPP;
}
/** /**
* emac_get_coalesce - Get interrupt coalesce settings for this device * emac_get_coalesce - Get interrupt coalesce settings for this device
* @ndev : The DaVinci EMAC network adapter * @ndev : The DaVinci EMAC network adapter
@ -622,12 +587,12 @@ static int emac_set_coalesce(struct net_device *ndev,
*/ */
static const struct ethtool_ops ethtool_ops = { static const struct ethtool_ops ethtool_ops = {
.get_drvinfo = emac_get_drvinfo, .get_drvinfo = emac_get_drvinfo,
.get_settings = emac_get_settings,
.set_settings = emac_set_settings,
.get_link = ethtool_op_get_link, .get_link = ethtool_op_get_link,
.get_coalesce = emac_get_coalesce, .get_coalesce = emac_get_coalesce,
.set_coalesce = emac_set_coalesce, .set_coalesce = emac_set_coalesce,
.get_ts_info = ethtool_op_get_ts_info, .get_ts_info = ethtool_op_get_ts_info,
.get_link_ksettings = phy_ethtool_get_link_ksettings,
.set_link_ksettings = phy_ethtool_set_link_ksettings,
}; };
/** /**