leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[media] s5p-csis: Correct the event counters logging

Browse Source 
The counter field is unsigned so >= 0 condition always evaluates
to true. Fix this to log events for which counter is > 0 or for
all when in debug mode.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Sylwester Nawrocki 2012-11-23 15:17:40 -03:00 committed by Mauro Carvalho Chehab
parent 1bc05e77db
commit ef2c83262a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/media/platform/s5p-fimc/mipi-csis.c
View File

@ -401,12 +401,12 @@ static void s5pcsis_log_counters(struct csis_state *state, bool non_errors)
spin_lock_irqsave(&state->slock, flags); spin_lock_irqsave(&state->slock, flags);
for (i--; i >= 0; i--) for (i--; i >= 0; i--) {
if (state->events[i].counter >= 0) if (state->events[i].counter > 0 || debug)
v4l2_info(&state->sd, "%s events: %d\n", v4l2_info(&state->sd, "%s events: %d\n",
state->events[i].name, state->events[i].name,
state->events[i].counter); state->events[i].counter);
}
spin_unlock_irqrestore(&state->slock, flags); spin_unlock_irqrestore(&state->slock, flags);
} }