leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: comedi: remove the "Allocate the subdevice..." comments

Browse Source 
These comments are redundant. The function name 'comedi_alloc_subdevices'
provides this information.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <ian@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2012-06-12 11:59:15 -07:00 committed by Greg Kroah-Hartman
parent 0e4039f311
commit eea6838b12
27 changed files with 3 additions and 84 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/staging/comedi/drivers/addi-data/addi_common.c
View File

@ -1686,7 +1686,6 @@ static int i_ADDI_Attach(struct comedi_device *dev, struct comedi_devconfig *it)
devpriv->s_BoardInfos.ui_Address = io_addr[2];
#endif
} else {
/* Update-0.7.57->0.7.68dev->n_subdevices = 7; */
n_subdevices = 7;
ret = comedi_alloc_subdevices(dev, n_subdevices);
if (ret < 0)

1
drivers/staging/comedi/drivers/addi-data/hwdrv_APCI1710.c
View File

@ -62,7 +62,6 @@ void i_ADDI_AttachPCI1710(struct comedi_device *dev)
int ret = 0;
int n_subdevices = 9;
/* Update-0.7.57->0.7.68dev->n_subdevices = 9; */
ret = comedi_alloc_subdevices(dev, n_subdevices);
if (ret < 0)
return;

4
drivers/staging/comedi/drivers/adq12b.c
View File

@ -267,10 +267,6 @@ static int adq12b_attach(struct comedi_device *dev, struct comedi_devconfig *it)
devpriv->last_channel = -1;
devpriv->last_range = -1;
/*
* Allocate the subdevice structures. alloc_subdevice() is a
* convenient macro defined in comedidev.h.
*/
if (comedi_alloc_subdevices(dev, 3) < 0)
return -ENOMEM;

1
drivers/staging/comedi/drivers/amplc_pci224.c
View File

@ -1379,7 +1379,6 @@ static int pci224_attach_common(struct comedi_device *dev,
outw(devpriv->daccon | PCI224_DACCON_FIFORESET,
dev->iobase + PCI224_DACCON);
/* Allocate subdevices. There is only one! */
ret = comedi_alloc_subdevices(dev, 1);
if (ret < 0)
return ret;

5
drivers/staging/comedi/drivers/amplc_pci230.c
View File

@ -2839,10 +2839,7 @@ static int pci230_attach_common(struct comedi_device *dev,
dev_dbg(dev->class_dev, "registered irq %u\n",
devpriv->pci_dev->irq);
}
/*
* Allocate the subdevice structures. alloc_subdevice() is a
* convenient macro defined in comedidev.h.
*/
if (comedi_alloc_subdevices(dev, 3) < 0)
return -ENOMEM;
s = dev->subdevices + 0;

1
drivers/staging/comedi/drivers/c6xdigio.c
View File

@ -433,7 +433,6 @@ static int c6xdigio_attach(struct comedi_device *dev,
dev->iobase = iobase;
dev->board_name = "c6xdigio";
/* 3 subdevices with encoder_init write */
result = comedi_alloc_subdevices(dev, 2);
if (result < 0)
return result;

3
drivers/staging/comedi/drivers/cb_pcidas.c
View File

@ -614,9 +614,6 @@ found:
/* Initialize dev->board_name */
dev->board_name = thisboard->name;
/*
* Allocate the subdevice structures.
*/
if (comedi_alloc_subdevices(dev, 7) < 0)
return -ENOMEM;

3
drivers/staging/comedi/drivers/cb_pcidda.c
View File

@ -333,9 +333,6 @@ found:
*/
dev->board_name = thisboard->name;
/*
* Allocate the subdevice structures.
*/
if (comedi_alloc_subdevices(dev, 3) < 0)
return -ENOMEM;

4
drivers/staging/comedi/drivers/cb_pcidio.c
View File

@ -177,10 +177,6 @@ found:
pci_resource_start(devpriv->pci_dev,
pcidio_boards[index].dioregs_badrindex);
/*
* Allocate the subdevice structures. alloc_subdevice() is a
* convenient macro defined in comedidev.h.
*/
if (comedi_alloc_subdevices(dev, thisboard->n_8255) < 0)
return -ENOMEM;

4
drivers/staging/comedi/drivers/cb_pcimdas.c
View File

@ -269,10 +269,6 @@ found:
/* Initialize dev->board_name */
dev->board_name = thisboard->name;
/*
* Allocate the subdevice structures. alloc_subdevice() is a
* convenient macro defined in comedidev.h.
*/
if (comedi_alloc_subdevices(dev, 3) < 0)
return -ENOMEM;

4
drivers/staging/comedi/drivers/cb_pcimdda.c
View File

@ -236,10 +236,6 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
*/
dev->board_name = thisboard->name;
/*
* Allocate the subdevice structures. alloc_subdevice() is a
* convenient macro defined in comedidev.h.
*/
if (comedi_alloc_subdevices(dev, 2) < 0)
return -ENOMEM;

4
drivers/staging/comedi/drivers/comedi_bond.c
View File

@ -358,10 +358,6 @@ static int bonding_attach(struct comedi_device *dev,
*/
dev->board_name = devpriv->name;
/*
* Allocate the subdevice structures. alloc_subdevice() is a
* convenient macro defined in comedidev.h.
*/
if (comedi_alloc_subdevices(dev, 1) < 0)
return -ENOMEM;

4
drivers/staging/comedi/drivers/dmm32at.c
View File

@ -371,10 +371,6 @@ static int dmm32at_attach(struct comedi_device *dev,
if (alloc_private(dev, sizeof(struct dmm32at_private)) < 0)
return -ENOMEM;
/*
* Allocate the subdevice structures. alloc_subdevice() is a
* convenient macro defined in comedidev.h.
*/
if (comedi_alloc_subdevices(dev, 3) < 0)
return -ENOMEM;

1
drivers/staging/comedi/drivers/dt9812.c
View File

@ -1035,7 +1035,6 @@ static int dt9812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
devpriv->serial = it->options[0];
/* Allocate subdevices */
if (comedi_alloc_subdevices(dev, 4) < 0)
return -ENOMEM;

1
drivers/staging/comedi/drivers/ke_counter.c
View File

@ -189,7 +189,6 @@ found:
io_base = pci_resource_start(pci_device, 0);
dev->iobase = io_base;
/* allocate the subdevice structures */
error = comedi_alloc_subdevices(dev, 1);
if (error < 0)
return error;

5
drivers/staging/comedi/drivers/me4000.c
View File

@ -2190,11 +2190,6 @@ static int me4000_attach(struct comedi_device *dev, struct comedi_devconfig *it)
if (result)
return result;
/*
* Allocate the subdevice structures. alloc_subdevice() is a
* convenient macro defined in comedidev.h. It relies on
* n_subdevices being set correctly.
*/
if (comedi_alloc_subdevices(dev, 4) < 0)
return -ENOMEM;

1
drivers/staging/comedi/drivers/mpc624.c
View File

@ -348,7 +348,6 @@ static int mpc624_attach(struct comedi_device *dev, struct comedi_devconfig *it)
devpriv->ulConvertionRate = MPC624_SPEED_3_52_kHz;
}
/* Subdevices structures */
if (comedi_alloc_subdevices(dev, 1) < 0)
return -ENOMEM;

7
drivers/staging/comedi/drivers/pcmda12.c
View File

@ -190,13 +190,6 @@ static int pcmda12_attach(struct comedi_device *dev,
devpriv->simultaneous_xfer_mode = it->options[1];
/*
* Allocate the subdevice structures. alloc_subdevice() is a
* convenient macro defined in comedidev.h.
*
* Allocate 2 subdevs (32 + 16 DIO lines) or 3 32 DIO subdevs for the
* 96-channel version of the board.
*/
if (comedi_alloc_subdevices(dev, 1) < 0)
return -ENOMEM;

7
drivers/staging/comedi/drivers/pcmmio.c
View File

@ -1071,12 +1071,7 @@ static int pcmmio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
dev->minor);
return -ENOMEM;
}
/*
* Allocate the subdevice structures. alloc_subdevice() is a
* convenient macro defined in comedidev.h.
*
* Allocate 1 AI + 1 AO + 2 DIO subdevs (24 lines per DIO)
*/
if (comedi_alloc_subdevices(dev, n_subdevs) < 0)
return -ENOMEM;

8
drivers/staging/comedi/drivers/pcmuio.c
View File

@ -800,13 +800,7 @@ static int pcmuio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
dev_warn(dev->hw_dev, "cannot allocate subdevice private data structures\n");
return -ENOMEM;
}
/*
* Allocate the subdevice structures. alloc_subdevice() is a
* convenient macro defined in comedidev.h.
*
* Allocate 2 subdevs (32 + 16 DIO lines) or 3 32 DIO subdevs for the
* 96-channel version of the board.
*/
if (comedi_alloc_subdevices(dev, n_subdevs) < 0)
return -ENOMEM;

4
drivers/staging/comedi/drivers/rtd520.c
View File

@ -1999,10 +1999,6 @@ static int rtd_attach(struct comedi_device *dev, struct comedi_devconfig *it)
/* Show board configuration */
printk(KERN_INFO "%s:", dev->board_name);
/*
* Allocate the subdevice structures. alloc_subdevice() is a
* convenient macro defined in comedidev.h.
*/
if (comedi_alloc_subdevices(dev, 4) < 0)
return -ENOMEM;

4
drivers/staging/comedi/drivers/s526.c
View File

@ -774,10 +774,6 @@ static int s526_attach(struct comedi_device *dev, struct comedi_devconfig *it)
if (alloc_private(dev, sizeof(struct s526_private)) < 0)
return -ENOMEM;
/*
* Allocate the subdevice structures. alloc_subdevice() is a
* convenient macro defined in comedidev.h.
*/
if (comedi_alloc_subdevices(dev, 4) < 0)
return -ENOMEM;

4
drivers/staging/comedi/drivers/skel.c
View File

@ -233,10 +233,6 @@ static int skel_attach(struct comedi_device *dev, struct comedi_devconfig *it)
if (alloc_private(dev, sizeof(struct skel_private)) < 0)
return -ENOMEM;
/*
* Allocate the subdevice structures. alloc_subdevice() is a
* convenient macro defined in comedidev.h.
*/
if (comedi_alloc_subdevices(dev, 3) < 0)
return -ENOMEM;

3
drivers/staging/comedi/drivers/ssv_dnp.c
View File

@ -197,9 +197,6 @@ static int dnp_attach(struct comedi_device *dev, struct comedi_devconfig *it)
if (alloc_private(dev, sizeof(struct dnp_private_data)) < 0)
return -ENOMEM;
/* Allocate the subdevice structures. alloc_subdevice() is a */
/* convenient macro defined in comedidev.h. */
if (comedi_alloc_subdevices(dev, 1) < 0)
return -ENOMEM;

1
drivers/staging/comedi/drivers/usbdux.c
View File

@ -2645,7 +2645,6 @@ static int usbdux_attach_common(struct comedi_device *dev,
n_subdevs = 4;
}
/* allocate space for the subdevices */
ret = comedi_alloc_subdevices(dev, n_subdevs);
if (ret < 0) {
up(&udev->sem);

1
drivers/staging/comedi/drivers/usbduxfast.c
View File

@ -1666,7 +1666,6 @@ static int usbduxfast_attach(struct comedi_device *dev,
dev->board_name = BOARDNAME;
/* allocate space for the subdevices */
ret = comedi_alloc_subdevices(dev, 1);
if (ret < 0) {
up(&(usbduxfastsub[index].sem));

1
drivers/staging/comedi/drivers/usbduxsigma.c
View File

@ -2690,7 +2690,6 @@ static int usbduxsigma_attach(struct comedi_device *dev,
n_subdevs = 3;
}
/* allocate space for the subdevices */
ret = comedi_alloc_subdevices(dev, n_subdevs);
if (ret < 0) {
up(&udev->sem);