leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Staging: lustre: Use setup_timer to combine initialization

Browse Source 
The function setup_timer combines the initialization of a timer with the
initialization of the timer's function and data fields.

So, this patch combines the multiline code for timer initialization using the function
setup_timer. This issue is identified via coccinelle script.

@@
expression E1, E2, E3;
type T;
@@
- init_timer(&E1);
...
(
- E1.function = E2;
...
- E1.data = (T)E3;
+ setup_timer(&E1, E2, (T)E3);
|
- E1.data = (T)E3;
...
- E1.function = E2;
+ setup_timer(&E1, E2, (T)E3);
|
- E1.function = E2;
+ setup_timer(&E1, E2, 0);
)

Signed-off-by: Somya Anand <somyaanand214@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Somya Anand 2015-03-11 17:02:15 +05:30 committed by Greg Kroah-Hartman
parent 5a2ca43fa5
commit ed0ed4ea77
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/lustre/lustre/llite/super25.c
View File

@ -152,9 +152,7 @@ static int __init init_lustre_lite(void)
do_gettimeofday(&tv); do_gettimeofday(&tv);
cfs_srand(tv.tv_sec ^ seed[0], tv.tv_usec ^ seed[1]); cfs_srand(tv.tv_sec ^ seed[0], tv.tv_usec ^ seed[1]);
setup_timer(&ll_capa_timer, ll_capa_timer_callback, 0);
init_timer(&ll_capa_timer);
ll_capa_timer.function = ll_capa_timer_callback;
rc = ll_capa_thread_start(); rc = ll_capa_thread_start();
if (rc != 0) if (rc != 0)
goto out_proc; goto out_proc;