leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

greybus: hid: fix success response being sent on errors

Browse Source 
Make sure to only send a success response if we did not detect any
errors.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
Johan Hovold 2015-03-27 12:45:45 +01:00 committed by Greg Kroah-Hartman
parent b67f2d13db
commit ecf47ab9c5
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/staging/greybus/hid.c
View File

@ -163,13 +163,6 @@ static void gb_hid_irq_handler(u8 type, struct gb_operation *op)
return; return;
} }
ret = gb_operation_response_send(op, 0);
if (ret) {
dev_err(&connection->dev,
"failed to send response status %d: %d\n",
0, ret);
}
size = request->report[0] | request->report[1] << 8; size = request->report[0] | request->report[1] << 8;
if (!size) { if (!size) {
dev_err(&connection->dev, "bad report size: %d\n", size); dev_err(&connection->dev, "bad report size: %d\n", size);
@ -179,6 +172,13 @@ static void gb_hid_irq_handler(u8 type, struct gb_operation *op)
if (test_bit(GB_HID_STARTED, &ghid->flags)) if (test_bit(GB_HID_STARTED, &ghid->flags))
hid_input_report(ghid->hid, HID_INPUT_REPORT, hid_input_report(ghid->hid, HID_INPUT_REPORT,
request->report + 2, size - 2, 1); request->report + 2, size - 2, 1);
ret = gb_operation_response_send(op, 0);
if (ret) {
dev_err(&connection->dev,
"failed to send response status %d: %d\n",
0, ret);
}
} }