leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IB/mlx5: Use ARRAY_SIZE

Browse Source 
Using the ARRAY_SIZE macro improves the readability of the code.

Found with Coccinelle with the following semantic patch:
@r depends on (org || report)@
type T;
T[] E;
position p;
@@
(
 (sizeof(E)@p /sizeof(*E))
|
 (sizeof(E)@p /sizeof(E[...]))
|
 (sizeof(E)@p /sizeof(T))
)

Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
Jérémy Lefaure 2017-10-16 08:45:17 +03:00 committed by Doug Ledford
parent 99260132fd
commit e980b44134
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/infiniband/hw/mlx5/odp.c
View File

@ -32,6 +32,7 @@
#include <rdma/ib_umem.h> #include <rdma/ib_umem.h>
#include <rdma/ib_umem_odp.h> #include <rdma/ib_umem_odp.h>
#include <linux/kernel.h>
#include "mlx5_ib.h" #include "mlx5_ib.h"
#include "cmd.h" #include "cmd.h"
@ -929,9 +930,8 @@ static int mlx5_ib_mr_initiator_pfault_handler(
return -EFAULT; return -EFAULT;
} }
if (unlikely(opcode >= sizeof(mlx5_ib_odp_opcode_cap) / if (unlikely(opcode >= ARRAY_SIZE(mlx5_ib_odp_opcode_cap) ||
sizeof(mlx5_ib_odp_opcode_cap[0]) || !(transport_caps & mlx5_ib_odp_opcode_cap[opcode]))) {
!(transport_caps & mlx5_ib_odp_opcode_cap[opcode]))) {
mlx5_ib_err(dev, "ODP fault on QP of an unsupported opcode 0x%x\n", mlx5_ib_err(dev, "ODP fault on QP of an unsupported opcode 0x%x\n",
opcode); opcode);
return -EFAULT; return -EFAULT;