leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

skge: Fix skge_set_ring_param() losing error return

Browse Source 
The error return is useful to caller, driver shouldn't miss it.

Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Wang Chen 2008-09-26 16:20:32 +08:00 committed by David S. Miller
parent 9ac1353f38
commit e824b3eb4a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/skge.c
View File

@ -501,7 +501,7 @@ static int skge_set_ring_param(struct net_device *dev,
struct ethtool_ringparam *p) struct ethtool_ringparam *p)
{ {
struct skge_port *skge = netdev_priv(dev); struct skge_port *skge = netdev_priv(dev);
int err; int err = 0;
if (p->rx_pending == 0 || p->rx_pending > MAX_RX_RING_SIZE || if (p->rx_pending == 0 || p->rx_pending > MAX_RX_RING_SIZE ||
p->tx_pending < TX_LOW_WATER || p->tx_pending > MAX_TX_RING_SIZE) p->tx_pending < TX_LOW_WATER || p->tx_pending > MAX_TX_RING_SIZE)
@ -517,7 +517,7 @@ static int skge_set_ring_param(struct net_device *dev,
dev_close(dev); dev_close(dev);
} }
return 0; return err;
} }
static u32 skge_get_msglevel(struct net_device *netdev) static u32 skge_get_msglevel(struct net_device *netdev)