leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: gadget: f_acm: don't disable disabled EP

Browse Source 
Make debugging real problems easier by not trying to disable an EP that
was not yet enabled.

Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
This commit is contained in:
Michał Mirosław 2020-05-28 20:30:28 +02:00 committed by Felipe Balbi
parent a1c0169a49
commit e7a0ed3fa3
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/usb/gadget/function/f_acm.c
View File

@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
/* we know alt == 0, so this is an activation or a reset */ /* we know alt == 0, so this is an activation or a reset */
if (intf == acm->ctrl_id) { if (intf == acm->ctrl_id) {
dev_vdbg(&cdev->gadget->dev, if (acm->notify->enabled) {
"reset acm control interface %d\n", intf); dev_vdbg(&cdev->gadget->dev,
usb_ep_disable(acm->notify); "reset acm control interface %d\n", intf);
usb_ep_disable(acm->notify);
}
if (!acm->notify->desc) if (!acm->notify->desc)
if (config_ep_by_speed(cdev->gadget, f, acm->notify)) if (config_ep_by_speed(cdev->gadget, f, acm->notify))