leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: pi433: remove unnecessary calling rf69_set_mode()

Browse Source 
Remove unnecessary rf69_set_mode() function call when rx is waiting for
a telegram. There is waste to call rf69_set_mode() twice for becoming
standby mode.

Signed-off-by: Sidong Yang <realwakka@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Sidong Yang 2019-03-24 14:54:41 +00:00 committed by Greg Kroah-Hartman
parent 344201e0f8
commit e5adddf5ae
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/staging/pi433/pi433_if.c
View File

@ -650,21 +650,19 @@ pi433_tx_thread(void *data)
disable_irq(device->irq_num[DIO0]); disable_irq(device->irq_num[DIO0]);
device->tx_active = true; device->tx_active = true;
/* clear fifo, set fifo threshold, set payload length */
retval = rf69_set_mode(spi, standby); /* this clears the fifo */
if (retval < 0)
return retval;
if (device->rx_active && !rx_interrupted) { if (device->rx_active && !rx_interrupted) {
/* /*
* rx is currently waiting for a telegram; * rx is currently waiting for a telegram;
* we need to set the radio module to standby * we need to set the radio module to standby
*/ */
retval = rf69_set_mode(device->spi, standby);
if (retval < 0)
return retval;
rx_interrupted = true; rx_interrupted = true;
} }
/* clear fifo, set fifo threshold, set payload length */
retval = rf69_set_mode(spi, standby); /* this clears the fifo */
if (retval < 0)
return retval;
retval = rf69_set_fifo_threshold(spi, FIFO_THRESHOLD); retval = rf69_set_fifo_threshold(spi, FIFO_THRESHOLD);
if (retval < 0) if (retval < 0)
return retval; return retval;