leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[media] tvp5150: get rid of KERN_CONT

Browse Source 
Unfortunately, KERN_CONT doesn't work with dev_foo(),
producing weird messages like:

	tvp5150 6-005c: tvp5150: read 0xf6 = 0xff
	ff

So, we need to get rid of it.

As we're always printing read/write in hexa when dumping
multiple register values, also remove the "0x" from the
read/write debug messages too.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Mauro Carvalho Chehab 2016-10-20 11:36:42 -02:00
parent ad0e374470
commit e513411489
1 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/media/i2c/tvp5150.c
View File

@ -102,20 +102,22 @@ static int tvp5150_write(struct v4l2_subdev *sd, unsigned char addr,
static void dump_reg_range(struct v4l2_subdev *sd, char *s, u8 init, static void dump_reg_range(struct v4l2_subdev *sd, char *s, u8 init,
const u8 end, int max_line) const u8 end, int max_line)
{ {
int i = 0; u8 buf[16];
int i = 0, j, len;
while (init != (u8)(end + 1)) { if (max_line > 16) {
if ((i % max_line) == 0) { dprintk0(sd->dev, "too much data to dump\n");
if (i > 0) return;
printk("\n"); }
printk("tvp5150: %s reg 0x%02x = ", s, init);
} for (i = init; i < end; i += max_line) {
printk("%02x ", tvp5150_read(sd, init)); len = (end - i > max_line) ? max_line : end - i;
init++; for (j = 0; j < len; j++)
i++; buf[j] = tvp5150_read(sd, i + j);
dprintk0(sd->dev, "%s reg %02x = %*ph\n", s, i, len, buf);
} }
printk("\n");
} }
static int tvp5150_log_status(struct v4l2_subdev *sd) static int tvp5150_log_status(struct v4l2_subdev *sd)