leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IB/hfi1: Remove unnecessary if check

Browse Source 
A for loop condition of data_iovs in user_sdma_free_request
is unnecessarily repeated before the loop as an if check.

Remove the if enveloping the loop.

Reviewed-by: Jakub Byczkowski <jakub.byczkowski@intel.com>
Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
Jan Sokolowski 2017-11-06 06:38:45 -08:00 committed by Doug Ledford
parent d61ea0751a
commit e4c397eed9
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/infiniband/hw/hfi1/user_sdma.c
View File

@ -1428,6 +1428,8 @@ static inline void pq_update(struct hfi1_user_sdma_pkt_q *pq)
static void user_sdma_free_request(struct user_sdma_request *req, bool unpin) static void user_sdma_free_request(struct user_sdma_request *req, bool unpin)
{ {
int i;
if (!list_empty(&req->txps)) { if (!list_empty(&req->txps)) {
struct sdma_txreq *t, *p; struct sdma_txreq *t, *p;
@ -1439,22 +1441,20 @@ static void user_sdma_free_request(struct user_sdma_request *req, bool unpin)
kmem_cache_free(req->pq->txreq_cache, tx); kmem_cache_free(req->pq->txreq_cache, tx);
} }
} }
if (req->data_iovs) {
struct sdma_mmu_node *node;
int i;
for (i = 0; i < req->data_iovs; i++) { for (i = 0; i < req->data_iovs; i++) {
node = req->iovs[i].node; struct sdma_mmu_node *node = req->iovs[i].node;
if (!node)
continue;
if (unpin) if (!node)
hfi1_mmu_rb_remove(req->pq->handler, continue;
&node->rb);
else if (unpin)
atomic_dec(&node->refcount); hfi1_mmu_rb_remove(req->pq->handler,
} &node->rb);
else
atomic_dec(&node->refcount);
} }
kfree(req->tids); kfree(req->tids);
clear_bit(req->info.comp_idx, req->pq->req_in_use); clear_bit(req->info.comp_idx, req->pq->req_in_use);
} }