leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ACPI: ioapic: Clear on-stack resource before using it

Browse Source 
The on-stack resource-window 'win' in setup_res() is not
properly initialized. This causes the pointers in the
embedded 'struct resource' to contain stale addresses.

These pointers (in my case the ->child pointer) later get
propagated to the global iomem_resources list, causing a #GP
exception when the list is traversed in
iomem_map_sanity_check().

Fixes: c183619b63 (x86/irq, ACPI: Implement ACPI driver to support IOAPIC hotplug)
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Joerg Roedel
2017-03-22 18:33:23 +01:00
committed by Rafael J. Wysocki
parent c02ed2e75e
commit e3d5092b67
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/acpi/ioapic.c
View File

@@ -45,6 +45,12 @@ static acpi_status setup_res(struct acpi_resource *acpi_res, void *data)
struct resource *res = data; struct resource *res = data;
struct resource_win win; struct resource_win win;
/*
* We might assign this to 'res' later, make sure all pointers are
* cleared before the resource is added to the global list
*/
memset(&win, 0, sizeof(win));
res->flags = 0; res->flags = 0;
if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM)) if (acpi_dev_filter_resource_type(acpi_res, IORESOURCE_MEM))
return AE_OK; return AE_OK;