leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

RDMA/device: Check that the rename is nop under the lock

Browse Source 
Since another rename could be running in parallel it is safer to check
that the name is not changing inside the lock, where we already know the
device name will not change.

Fixes: d21943dd19 ("RDMA/core: Implement IB device rename function")
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Reviewed-by: Parav Pandit <parav@mellanox.com>
This commit is contained in:
Jason Gunthorpe 2019-02-06 22:41:47 -07:00
parent 21a428a019
commit e3593b568a
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/infiniband/core/device.c
View File

@ -189,12 +189,14 @@ static struct ib_device *__ib_device_get_by_name(const char *name)
int ib_device_rename(struct ib_device *ibdev, const char *name)
{
int ret = 0;
if (!strcmp(name, dev_name(&ibdev->dev)))
return ret;
int ret;
mutex_lock(&device_mutex);
if (!strcmp(name, dev_name(&ibdev->dev))) {
ret = 0;
goto out;
}
if (__ib_device_get_by_name(name)) {
ret = -EEXIST;
goto out;