leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gfs2: Fix unused value warning in do_gfs2_set_flags()

Browse Source 
Coverity complains of an unused value:

CID 119623 ( of 1): Unused value (UNUSED_VALUE)
assigned_value: Assigning value -1 to error here, but that stored value is
overwritten before it can be used.
237        error = -EPERM;

Fix it by removing the assignment.

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
This commit is contained in:
Tim Gardner 2021-09-20 13:05:18 -06:00 committed by Andreas Gruenbacher
parent 660a6126f8
commit e34e6f8133
1 changed files with 0 additions and 1 deletions

1
fs/gfs2/file.c
View File

@ -234,7 +234,6 @@ static int do_gfs2_set_flags(struct inode *inode, u32 reqflags, u32 mask)
if ((new_flags ^ flags) == 0)
goto out;
error = -EPERM;
if (!IS_IMMUTABLE(inode)) {
error = gfs2_permission(&init_user_ns, inode, MAY_WRITE);
if (error)