leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[NET]: should explicitely initialize atomic_t field in struct dst_ops

Browse Source 
All but one struct dst_ops static initializations miss explicit
initialization of entries field.

As this field is atomic_t, we should use ATOMIC_INIT(0), and not
rely on atomic_t implementation.

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Dumazet 2008-01-30 20:07:45 -08:00 committed by David S. Miller
parent ad1984e844
commit e242297055
4 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/ipv4/route.c
View File

@ -169,6 +169,7 @@ static struct dst_ops ipv4_dst_ops = {
.update_pmtu = ip_rt_update_pmtu, .update_pmtu = ip_rt_update_pmtu,
.local_out = ip_local_out, .local_out = ip_local_out,
.entry_size = sizeof(struct rtable), .entry_size = sizeof(struct rtable),
.entries = ATOMIC_INIT(0),
}; };
#define ECN_OR_COST(class) TC_PRIO_##class #define ECN_OR_COST(class) TC_PRIO_##class
@ -2498,6 +2499,7 @@ static struct dst_ops ipv4_dst_blackhole_ops = {
.check = ipv4_dst_check, .check = ipv4_dst_check,
.update_pmtu = ipv4_rt_blackhole_update_pmtu, .update_pmtu = ipv4_rt_blackhole_update_pmtu,
.entry_size = sizeof(struct rtable), .entry_size = sizeof(struct rtable),
.entries = ATOMIC_INIT(0),
}; };

1
net/ipv4/xfrm4_policy.c
View File

@ -247,6 +247,7 @@ static struct dst_ops xfrm4_dst_ops = {
.local_out = __ip_local_out, .local_out = __ip_local_out,
.gc_thresh = 1024, .gc_thresh = 1024,
.entry_size = sizeof(struct xfrm_dst), .entry_size = sizeof(struct xfrm_dst),
.entries = ATOMIC_INIT(0),
}; };
static struct xfrm_policy_afinfo xfrm4_policy_afinfo = { static struct xfrm_policy_afinfo xfrm4_policy_afinfo = {

2
net/ipv6/route.c
View File

@ -107,6 +107,7 @@ static struct dst_ops ip6_dst_ops = {
.update_pmtu = ip6_rt_update_pmtu, .update_pmtu = ip6_rt_update_pmtu,
.local_out = ip6_local_out, .local_out = ip6_local_out,
.entry_size = sizeof(struct rt6_info), .entry_size = sizeof(struct rt6_info),
.entries = ATOMIC_INIT(0),
}; };
static void ip6_rt_blackhole_update_pmtu(struct dst_entry *dst, u32 mtu) static void ip6_rt_blackhole_update_pmtu(struct dst_entry *dst, u32 mtu)
@ -120,6 +121,7 @@ static struct dst_ops ip6_dst_blackhole_ops = {
.check = ip6_dst_check, .check = ip6_dst_check,
.update_pmtu = ip6_rt_blackhole_update_pmtu, .update_pmtu = ip6_rt_blackhole_update_pmtu,
.entry_size = sizeof(struct rt6_info), .entry_size = sizeof(struct rt6_info),
.entries = ATOMIC_INIT(0),
}; };
struct rt6_info ip6_null_entry = { struct rt6_info ip6_null_entry = {

1
net/ipv6/xfrm6_policy.c
View File

@ -272,6 +272,7 @@ static struct dst_ops xfrm6_dst_ops = {
.local_out = __ip6_local_out, .local_out = __ip6_local_out,
.gc_thresh = 1024, .gc_thresh = 1024,
.entry_size = sizeof(struct xfrm_dst), .entry_size = sizeof(struct xfrm_dst),
.entries = ATOMIC_INIT(0),
}; };
static struct xfrm_policy_afinfo xfrm6_policy_afinfo = { static struct xfrm_policy_afinfo xfrm6_policy_afinfo = {