leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

md/raid5-ppl: Drop unused argument from ppl_handle_flush_request()

Browse Source 
ppl_handle_flush_request() takes an struct r5log argument but doesn't
use it. It has no buisiness taking this argument as it is only used
by raid5-cache and has no way to derference it anyway. Remove
the argument.

No functional changes intended.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Song Liu <song@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Logan Gunthorpe 2022-06-08 10:27:48 -06:00 committed by Jens Axboe
parent ed0c6a5fbe
commit e0fccdafc2
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/md/raid5-log.h
View File

@ -41,7 +41,7 @@ void ppl_write_stripe_run(struct r5conf *conf);
void ppl_stripe_write_finished(struct stripe_head *sh); void ppl_stripe_write_finished(struct stripe_head *sh);
int ppl_modify_log(struct r5conf *conf, struct md_rdev *rdev, bool add); int ppl_modify_log(struct r5conf *conf, struct md_rdev *rdev, bool add);
void ppl_quiesce(struct r5conf *conf, int quiesce); void ppl_quiesce(struct r5conf *conf, int quiesce);
int ppl_handle_flush_request(struct r5l_log *log, struct bio *bio); int ppl_handle_flush_request(struct bio *bio);
extern struct md_sysfs_entry ppl_write_hint; extern struct md_sysfs_entry ppl_write_hint;
static inline bool raid5_has_log(struct r5conf *conf) static inline bool raid5_has_log(struct r5conf *conf)
@ -108,7 +108,7 @@ static inline int log_handle_flush_request(struct r5conf *conf, struct bio *bio)
if (conf->log) if (conf->log)
ret = r5l_handle_flush_request(conf->log, bio); ret = r5l_handle_flush_request(conf->log, bio);
else if (raid5_has_ppl(conf)) else if (raid5_has_ppl(conf))
ret = ppl_handle_flush_request(conf->log, bio); ret = ppl_handle_flush_request(bio);
return ret; return ret;
} }

2
drivers/md/raid5-ppl.c
View File

@ -679,7 +679,7 @@ void ppl_quiesce(struct r5conf *conf, int quiesce)
} }
} }
int ppl_handle_flush_request(struct r5l_log *log, struct bio *bio) int ppl_handle_flush_request(struct bio *bio)
{ {
if (bio->bi_iter.bi_size == 0) { if (bio->bi_iter.bi_size == 0) {
bio_endio(bio); bio_endio(bio);