leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

befs: don't pass huge structs by value

Browse Source 
'struct befs_disk_data_stream' is huge (~144 bytes) and it's being passed
by value in fs/befs/endian.h::cpu_to_fsrun().

It would be better to pass a pointer.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Cc: Will Dyson <will_dyson@pobox.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jesper Juhl 2011-01-12 17:00:26 -08:00 committed by Linus Torvalds
parent 25f959d63d
commit e0e3d32bb4
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
fs/befs/endian.h
View File

@ -102,22 +102,22 @@ cpu_to_fsrun(const struct super_block *sb, befs_block_run n)
}
static inline befs_data_stream
fsds_to_cpu(const struct super_block *sb, befs_disk_data_stream n)
fsds_to_cpu(const struct super_block *sb, const befs_disk_data_stream *n)
{
befs_data_stream data;
int i;
for (i = 0; i < BEFS_NUM_DIRECT_BLOCKS; ++i)
data.direct[i] = fsrun_to_cpu(sb, n.direct[i]);
data.direct[i] = fsrun_to_cpu(sb, n->direct[i]);
data.max_direct_range = fs64_to_cpu(sb, n.max_direct_range);
data.indirect = fsrun_to_cpu(sb, n.indirect);
data.max_indirect_range = fs64_to_cpu(sb, n.max_indirect_range);
data.double_indirect = fsrun_to_cpu(sb, n.double_indirect);
data.max_direct_range = fs64_to_cpu(sb, n->max_direct_range);
data.indirect = fsrun_to_cpu(sb, n->indirect);
data.max_indirect_range = fs64_to_cpu(sb, n->max_indirect_range);
data.double_indirect = fsrun_to_cpu(sb, n->double_indirect);
data.max_double_indirect_range = fs64_to_cpu(sb,
n.
n->
max_double_indirect_range);
data.size = fs64_to_cpu(sb, n.size);
data.size = fs64_to_cpu(sb, n->size);
return data;
}

2
fs/befs/linuxvfs.c
View File

@ -390,7 +390,7 @@ static struct inode *befs_iget(struct super_block *sb, unsigned long ino)
int num_blks;
befs_ino->i_data.ds =
fsds_to_cpu(sb, raw_inode->data.datastream);
fsds_to_cpu(sb, &raw_inode->data.datastream);
num_blks = befs_count_blocks(sb, &befs_ino->i_data.ds);
inode->i_blocks =