leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

scsi: libfc: Check xid when looking up REC exchanges

Browse Source 
We currently can only lookup the local xid, so we need
to reject REC with empty rxid.

Signed-off-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Hannes Reinecke
2016-10-13 15:10:55 +02:00
committed by Martin K. Petersen
parent 87da3b832e
commit e0a25286d8
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/scsi/libfc/fc_exch.c
View File

@@ -2005,8 +2005,7 @@ static void fc_exch_els_rec(struct fc_frame *rfp)
enum fc_els_rjt_reason reason = ELS_RJT_LOGIC; enum fc_els_rjt_reason reason = ELS_RJT_LOGIC;
enum fc_els_rjt_explan explan; enum fc_els_rjt_explan explan;
u32 sid; u32 sid;
u16 rxid; u16 xid, rxid, oxid;
u16 oxid;
lport = fr_dev(rfp); lport = fr_dev(rfp);
rp = fc_frame_payload_get(rfp, sizeof(*rp)); rp = fc_frame_payload_get(rfp, sizeof(*rp));
@@ -2017,9 +2016,18 @@ static void fc_exch_els_rec(struct fc_frame *rfp)
rxid = ntohs(rp->rec_rx_id); rxid = ntohs(rp->rec_rx_id);
oxid = ntohs(rp->rec_ox_id); oxid = ntohs(rp->rec_ox_id);
ep = fc_exch_lookup(lport,
sid == fc_host_port_id(lport->host) ? oxid : rxid);
explan = ELS_EXPL_OXID_RXID; explan = ELS_EXPL_OXID_RXID;
if (sid == fc_host_port_id(lport->host))
xid = oxid;
else
xid = rxid;
if (xid == FC_XID_UNKNOWN) {
FC_LPORT_DBG(lport,
"REC request from %x: invalid rxid %x oxid %x\n",
sid, rxid, oxid);
goto reject;
}
ep = fc_exch_lookup(lport, xid);
if (!ep) { if (!ep) {
FC_LPORT_DBG(lport, FC_LPORT_DBG(lport,
"REC request from %x: rxid %x oxid %x not found\n", "REC request from %x: rxid %x oxid %x not found\n",