leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tracing/kprobes: 'nmissed' not showed correctly for kretprobe

Browse Source 
The 'nmissed' column of the 'kprobe_profile' file for kretprobe is
not showed correctly, kretprobe can be skipped by two reasons,
shortage of kretprobe_instance which is counted by tk->rp.nmissed,
and kprobe itself is missed by some reason, so to show the sum.

Link: https://lkml.kernel.org/r/20220107150242.5019-1-xyz.sun.ok@gmail.com

Cc: stable@vger.kernel.org
Fixes: 4a846b443b ("tracing/kprobes: Cleanup kprobe tracer code")
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Xiangyang Zhang <xyz.sun.ok@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
This commit is contained in:
Xiangyang Zhang
2022-01-07 23:02:42 +08:00
committed by Steven Rostedt
parent 77360f9bbc
commit dfea08a211
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
kernel/trace/trace_kprobe.c
View File

@@ -1170,15 +1170,18 @@ static int probes_profile_seq_show(struct seq_file *m, void *v)
{ {
struct dyn_event *ev = v; struct dyn_event *ev = v;
struct trace_kprobe *tk; struct trace_kprobe *tk;
unsigned long nmissed;
if (!is_trace_kprobe(ev)) if (!is_trace_kprobe(ev))
return 0; return 0;
tk = to_trace_kprobe(ev); tk = to_trace_kprobe(ev);
nmissed = trace_kprobe_is_return(tk) ?
tk->rp.kp.nmissed + tk->rp.nmissed : tk->rp.kp.nmissed;
seq_printf(m, " %-44s %15lu %15lu\n", seq_printf(m, " %-44s %15lu %15lu\n",
trace_probe_name(&tk->tp), trace_probe_name(&tk->tp),
trace_kprobe_nhit(tk), trace_kprobe_nhit(tk),
tk->rp.kp.nmissed); nmissed);
return 0; return 0;
} }