net: dsa: fix dsa_is_normal_port helper
In order to know if a port is of type user, dsa_is_normal_port checks that the given port is not of type DSA nor CPU. This is not enough because a port can be unused. Without the previous fix, this caused the unused mv88e6xxx ports to be configured in normal mode. The ds->enabled_port_mask reports the user ports, so check this instead. Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
91dee14481
commit
deb8ee0b51
@ -273,7 +273,7 @@ static inline bool dsa_is_dsa_port(struct dsa_switch *ds, int p)
|
||||
|
||||
static inline bool dsa_is_normal_port(struct dsa_switch *ds, int p)
|
||||
{
|
||||
return !dsa_is_cpu_port(ds, p) && !dsa_is_dsa_port(ds, p);
|
||||
return !!(ds->enabled_port_mask & BIT(p));
|
||||
}
|
||||
|
||||
static inline const struct dsa_port *dsa_to_port(struct dsa_switch *ds, int p)
|
||||
|
Loading…
Reference in New Issue
Block a user