leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[media] media: lirc_dev: clarify error handling

Browse Source 
If an error is generated, it is more logical to error out ASAP.

Signed-off-by: David Härdeman <david@hardeman.nu>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
David Härdeman 2017-06-25 09:31:19 -03:00 committed by Mauro Carvalho Chehab
parent cf09e3c904
commit de226ec8a6
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/media/rc/lirc_dev.c
View File

@ -286,7 +286,7 @@ EXPORT_SYMBOL(lirc_unregister_driver);
int lirc_dev_fop_open(struct inode *inode, struct file *file) int lirc_dev_fop_open(struct inode *inode, struct file *file)
{ {
struct irctl *ir; struct irctl *ir;
int retval = 0; int retval;
if (iminor(inode) >= MAX_IRCTL_DEVICES) { if (iminor(inode) >= MAX_IRCTL_DEVICES) {
pr_err("open result for %d is -ENODEV\n", iminor(inode)); pr_err("open result for %d is -ENODEV\n", iminor(inode));
@ -327,9 +327,11 @@ int lirc_dev_fop_open(struct inode *inode, struct file *file)
ir->open++; ir->open++;
error:
nonseekable_open(inode, file); nonseekable_open(inode, file);
return 0;
error:
return retval; return retval;
} }
EXPORT_SYMBOL(lirc_dev_fop_open); EXPORT_SYMBOL(lirc_dev_fop_open);