leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xfs: fix transaction leak on remote attr set/remove failure

Browse Source 
The xattr remote value set/remove handlers both clear args.trans in
the error path without having cancelled the transaction. This leaks
the transaction, causes warnings around returning to userspace with
locks held and leads to system lockups or other general problems.

The higher level xfs_attr_[set|remove]() functions already detect
and cancel args.trans when set in the error path. Drop the NULL
assignments from the rmtval handlers and allow the callers to clean
up the transaction correctly.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
This commit is contained in:
Brian Foster 2018-07-24 13:43:08 -07:00 committed by Darrick J. Wong
parent a61acc3c78
commit dcbd44f799
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/xfs/libxfs/xfs_attr_remote.c
View File

@ -558,7 +558,6 @@ xfs_attr_rmtval_set(
return 0;
out_defer_cancel:
xfs_defer_cancel(args->trans->t_dfops);
args->trans = NULL;
return error;
}
@ -646,6 +645,5 @@ xfs_attr_rmtval_remove(
return 0;
out_defer_cancel:
xfs_defer_cancel(args->trans->t_dfops);
args->trans = NULL;
return error;
}