leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

scsi: ufs: disable irq before disabling clocks

Browse Source 
During suspend flow, interrupt shall be disabled before disabling clocks to
avoid potential system hang due to accessing host registers after host
clocks are disabled.

For example, if an interrupt comes with IRQF_IRQPOLL flag configured with
the misrouted interrupt recovery feature enabled, ufshcd ISR may be
triggered even if nothing shall be done for UFS. In this case, system hang
may happen if UFS interrupt status register is accessed with host clocks
disabled.

Link: https://lore.kernel.org/r/1575721321-8071-2-git-send-email-stanley.chu@mediatek.com
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Stanley Chu 2019-12-07 20:22:00 +08:00 committed by Martin K. Petersen
parent dc30c9e6d6
commit dcb6cec508
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/scsi/ufs/ufshcd.c
View File

@ -7890,6 +7890,11 @@ disable_clks:
ret = ufshcd_vops_suspend(hba, pm_op); ret = ufshcd_vops_suspend(hba, pm_op);
if (ret) if (ret)
goto set_link_active; goto set_link_active;
/*
* Disable the host irq as host controller as there won't be any
* host controller transaction expected till resume.
*/
ufshcd_disable_irq(hba);
if (!ufshcd_is_link_active(hba)) if (!ufshcd_is_link_active(hba))
ufshcd_setup_clocks(hba, false); ufshcd_setup_clocks(hba, false);
@ -7899,11 +7904,7 @@ disable_clks:
hba->clk_gating.state = CLKS_OFF; hba->clk_gating.state = CLKS_OFF;
trace_ufshcd_clk_gating(dev_name(hba->dev), hba->clk_gating.state); trace_ufshcd_clk_gating(dev_name(hba->dev), hba->clk_gating.state);
/*
* Disable the host irq as host controller as there won't be any
* host controller transaction expected till resume.
*/
ufshcd_disable_irq(hba);
/* Put the host controller in low power mode if possible */ /* Put the host controller in low power mode if possible */
ufshcd_hba_vreg_set_lpm(hba); ufshcd_hba_vreg_set_lpm(hba);
goto out; goto out;