From dbbe358b13706d86d1945a010f5d2a34b8c81d06 Mon Sep 17 00:00:00 2001 From: Oded Gabbay Date: Sat, 2 Mar 2019 11:43:12 +0200 Subject: [PATCH] habanalabs: use %px instead of %p in error print When parsing the address of an internal command buffer, the driver prints an error if the buffer's address is not in the range of the device's DRAM or SRAM memory address space. Use %px to print the real address that the user gave the driver and not a hashed value, so the user will get a clue regarding the origin of his error. Note that if the print occurs, the pointer that is printed is a user's virtual address and not some kind of physical address. Suggested-by: Joe Perches Signed-off-by: Oded Gabbay Signed-off-by: Greg Kroah-Hartman --- drivers/misc/habanalabs/goya/goya.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c index c4f3ec1e9d8b..238dd57c541b 100644 --- a/drivers/misc/habanalabs/goya/goya.c +++ b/drivers/misc/habanalabs/goya/goya.c @@ -4293,7 +4293,7 @@ static int goya_parse_cb_no_ext_quque(struct hl_device *hdev, return 0; dev_err(hdev->dev, - "Internal CB address %p + 0x%x is not in SRAM nor in DRAM\n", + "Internal CB address %px + 0x%x is not in SRAM nor in DRAM\n", parser->user_cb, parser->user_cb_size); return -EFAULT;