leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gve: fix dma sync bug where not all pages synced

Browse Source 
The previous commit had a bug where the last page in the memory range
could not be synced. This change fixes the behavior so that all the
required pages are synced.

Fixes: 9cfeeb576d ("gve: Fixes DMA synchronization")
Signed-off-by: Adi Suresh <adisuresh@google.com>
Reviewed-by: Catherine Sullivan <csully@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Adi Suresh 2019-11-19 08:02:47 -08:00 committed by David S. Miller
parent 075e238d12
commit db96c2cb48
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/net/ethernet/google/gve/gve_tx.c
View File

@ -393,12 +393,13 @@ static void gve_tx_fill_seg_desc(union gve_tx_desc *seg_desc,
static void gve_dma_sync_for_device(struct device *dev, dma_addr_t *page_buses, static void gve_dma_sync_for_device(struct device *dev, dma_addr_t *page_buses,
u64 iov_offset, u64 iov_len) u64 iov_offset, u64 iov_len)
{ {
u64 last_page = (iov_offset + iov_len - 1) / PAGE_SIZE;
u64 first_page = iov_offset / PAGE_SIZE;
dma_addr_t dma; dma_addr_t dma;
u64 addr; u64 page;
for (addr = iov_offset; addr < iov_offset + iov_len; for (page = first_page; page <= last_page; page++) {
addr += PAGE_SIZE) { dma = page_buses[page];
dma = page_buses[addr / PAGE_SIZE];
dma_sync_single_for_device(dev, dma, PAGE_SIZE, DMA_TO_DEVICE); dma_sync_single_for_device(dev, dma, PAGE_SIZE, DMA_TO_DEVICE);
} }
} }