leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ipv6: Create cleanup helper for fib6_nh

Browse Source 
Move the fib6_nh cleanup code to a new helper, fib6_nh_release.

Signed-off-by: David Ahern <dsahern@gmail.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
David Ahern
2019-03-27 20:53:51 -07:00
committed by David S. Miller
parent 83c4425159
commit dac7d0f270
3 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
include/net/ip6_fib.h
View File

@@ -447,6 +447,7 @@ static inline struct net_device *fib6_info_nh_dev(const struct fib6_info *f6i)
int fib6_nh_init(struct net *net, struct fib6_nh *fib6_nh, int fib6_nh_init(struct net *net, struct fib6_nh *fib6_nh,
struct fib6_config *cfg, gfp_t gfp_flags, struct fib6_config *cfg, gfp_t gfp_flags,
struct netlink_ext_ack *extack); struct netlink_ext_ack *extack);
void fib6_nh_release(struct fib6_nh *fib6_nh);
static inline static inline
struct lwtunnel_state *fib6_info_nh_lwt(const struct fib6_info *f6i) struct lwtunnel_state *fib6_info_nh_lwt(const struct fib6_info *f6i)

5
net/ipv6/ip6_fib.c
View File

@@ -199,10 +199,7 @@ void fib6_info_destroy_rcu(struct rcu_head *head)
free_percpu(f6i->rt6i_pcpu); free_percpu(f6i->rt6i_pcpu);
} }
lwtstate_put(f6i->fib6_nh.nh_lwtstate); fib6_nh_release(&f6i->fib6_nh);
if (f6i->fib6_nh.nh_dev)
dev_put(f6i->fib6_nh.nh_dev);
ip_fib_metrics_put(f6i->fib6_metrics); ip_fib_metrics_put(f6i->fib6_metrics);

8
net/ipv6/route.c
View File

@@ -3025,6 +3025,14 @@ out:
return err; return err;
} }
void fib6_nh_release(struct fib6_nh *fib6_nh)
{
lwtstate_put(fib6_nh->nh_lwtstate);
if (fib6_nh->nh_dev)
dev_put(fib6_nh->nh_dev);
}
static struct fib6_info *ip6_route_info_create(struct fib6_config *cfg, static struct fib6_info *ip6_route_info_create(struct fib6_config *cfg,
gfp_t gfp_flags, gfp_t gfp_flags,
struct netlink_ext_ack *extack) struct netlink_ext_ack *extack)