leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bna: fill the magic in bnad_get_eeprom() instead of validating

Browse Source 
A driver should fill magic field of ethtool_eeprom struct in .get_eeprom
and validate it in .set_eeprom. The bna incorrectly validates it in both
and this makes its .get_eeprom interface unusable.

Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ivan Vecera 2014-07-28 15:03:52 +02:00 committed by David S. Miller
parent 26bcd8b725
commit dabf24d168
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ethernet/brocade/bna/bnad_ethtool.c
View File

@ -997,10 +997,8 @@ bnad_get_eeprom(struct net_device *netdev, struct ethtool_eeprom *eeprom,
unsigned long flags = 0; unsigned long flags = 0;
int ret = 0; int ret = 0;
/* Check if the flash read request is valid */ /* Fill the magic value */
if (eeprom->magic != (bnad->pcidev->vendor | eeprom->magic = bnad->pcidev->vendor | (bnad->pcidev->device << 16);
(bnad->pcidev->device << 16)))
return -EFAULT;
/* Query the flash partition based on the offset */ /* Query the flash partition based on the offset */
flash_part = bnad_get_flash_partition_by_offset(bnad, flash_part = bnad_get_flash_partition_by_offset(bnad,